Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 98137 third_party/iccjpeg fails licensecheck
Starred by 4 users Project Member Reported by phajdan.jr@chromium.org, Sep 26 2011 Back to list
Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 28291



Sign in to add a comment
$ tools/checklicenses/checklicenses.py --ignore-suppressions third_party/iccjpeg/
'third_party/iccjpeg/iccjpeg.c' has non-whitelisted license 'UNKNOWN'
'third_party/iccjpeg/iccjpeg.h' has non-whitelisted license 'UNKNOWN'

Please make sure those files have license headers and make third_party/devscripts/licensecheck.pl recognize them. Patches to that script should be submitted upstream.
 
Blocking: 28291
A clarifying update:

1. Make sure all files in question have license headers that identify the license. It doesn't have to contain full text of the license, but it should identify the license type precisely enough, e.g. "APSL" or "BSD (3-clause)".

   - if the project in question is developed by Google, there is no excuse; go and fix it
   - if it's a third party project, we should ask them to add license headers (a bug should be filed); then you can put the third party bug link in the Chromium bug and change the Chromium bug status to ExternalDependency

2. We don't add the license headers ourselves to code we didn't write. Added because people asked about that.

3. If the files have license headers but they're still not recognized, third_party/devscripts/licensecheck.pl should be patched. Please remember to also update chromium-1.patch (you can get original licensecheck.pl by reverse-applying that patch). You _don't_ need to upstream your changes, I'll take care of that. In fact, if you don't feel like messing with perl or reverse-applying things, just send me your regular expressions (make sure they're good).

4. Finnally, the suppression should be removed from tools/checklicenses/checklicenses.py . Please respect OWNERS of that file.

That should be it, thank you for your feedback and work on the bugs (11 bugs have already been fixed).
Project Member Comment 4 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals Cr-Internals
Status: Started
The key to satisfying tools/checklicenses/checklicenses.py is to refer to README file:

 * Copyright (C) 1991-1998, Thomas G. Lane.
 * This file is part of the Independent JPEG Group's software.
 * For conditions of distribution and use, see the accompanying README file.
 *

Initially this library provided a LICENSE file, but not README.  Referring to LICENSE file:
 * For conditions of distribution and use, see the accompanying LICENSE file.
is not sufficient to satisfy tools/checklicenses/checklicenses.py

Follow what libjpeg did and have README file, and a LICENSE file that contains a copy and a header that:
(Copied from the README.)

--------------------------------------------------------------------------------


Project Member Comment 6 by bugdroid1@chromium.org, Aug 3 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1a8185c72545ce458e3898e98c0dae095977f0e

commit a1a8185c72545ce458e3898e98c0dae095977f0e
Author: fbarchard <fbarchard@google.com>
Date: Wed Aug 03 19:54:38 2016

iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG= 98137 
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions third_party/iccjpeg/
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2182993003
Cr-Commit-Position: refs/heads/master@{#409600}

[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/LICENSE
[add] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/README
[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/README.chromium
[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/iccjpeg.c
[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/iccjpeg.h

Project Member Comment 7 by bugdroid1@chromium.org, Aug 3 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1a8185c72545ce458e3898e98c0dae095977f0e

commit a1a8185c72545ce458e3898e98c0dae095977f0e
Author: fbarchard <fbarchard@google.com>
Date: Wed Aug 03 19:54:38 2016

iccjpeg: Add README with license information.

Make source files refer to README for license details.
Covered by same copyright and license as libjpeg.

BUG= 98137 
TESTED=tools/checklicenses/checklicenses.py --ignore-suppressions third_party/iccjpeg/
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2182993003
Cr-Commit-Position: refs/heads/master@{#409600}

[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/LICENSE
[add] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/README
[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/README.chromium
[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/iccjpeg.c
[modify] https://crrev.com/a1a8185c72545ce458e3898e98c0dae095977f0e/third_party/iccjpeg/iccjpeg.h

Status: Fixed
Consider followup to upstream icc source and license files.
Sign in to add a comment