Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 98120 third_party/cld fails licensecheck
Starred by 2 users Project Member Reported by phajdan.jr@chromium.org, Sep 26 2011 Back to list
Status: Fixed
Owner:
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 28291



Sign in to add a comment
$ tools/checklicenses/checklicenses.py --ignore-suppressions third_party/cld
'third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_ctjkvz_0.cc' has non-whitelisted license 'UNKNOWN'
'third_party/cld/encodings/compact_lang_det/win/cld_utf8utils_google3.cc' has non-whitelisted license 'UNKNOWN'
'third_party/cld/encodings/compact_lang_det/subsetsequence_unittest.cc' has non-whitelisted license 'UNKNOWN'
 
Please make sure those files have license headers and make third_party/devscripts/licensecheck.pl recognize them. Patches to that script should be submitted upstream.
Owner: mad@chromium.org
Blocking: 28291
A clarifying update:

1. Make sure all files in question have license headers that identify the license. It doesn't have to contain full text of the license, but it should identify the license type precisely enough, e.g. "APSL" or "BSD (3-clause)".

   - if the project in question is developed by Google, there is no excuse; go and fix it
   - if it's a third party project, we should ask them to add license headers (a bug should be filed); then you can put the third party bug link in the Chromium bug and change the Chromium bug status to ExternalDependency

2. We don't add the license headers ourselves to code we didn't write. Added because people asked about that.

3. If the files have license headers but they're still not recognized, third_party/devscripts/licensecheck.pl should be patched. Please remember to also update chromium-1.patch (you can get original licensecheck.pl by reverse-applying that patch). You _don't_ need to upstream your changes, I'll take care of that. In fact, if you don't feel like messing with perl or reverse-applying things, just send me your regular expressions (make sure they're good).

4. Finnally, the suppression should be removed from tools/checklicenses/checklicenses.py . Please respect OWNERS of that file.

That should be it, thank you for your feedback and work on the bugs (11 bugs have already been fixed).
Comment 6 by mad@chromium.org, Oct 17 2012
Cc: dsites@google.com alekseys@chromium.org
These files are generated by an internal tool... I could change the files in the Chromium repo, but we will also need to modify the internal generators...
We have special logic for generated file in licensecheck.pl . Generally something in the files should say they are auto-generated, or licensecheck.pl can be modified to recognize your version.

If in doubt, I'm happy to help, please contact me off-line if you want.
Project Member Comment 8 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals Cr-Internals
Comment 9 by mad@chromium.org, Mar 18 2013
Cc: kenjibaheux@chromium.org
Owner: ----
Status: Available
Comment 10 by mad@chromium.org, Mar 19 2013
Owner: toyoshim@chromium.org
Status: Assigned
Feel free to find another owner...
Labels: -Pri-2 Pri-3 M-28 Cr-UI-Browser-Translate
ok. I'll handle this.
Status: Fixed
Components: -UI>Browser>Translate UI>Browser>Language>Translate
Sign in to add a comment