New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2011
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 97177: bookmark bar visible in full screen

Reported by est...@chromium.org, Sep 20 2011 Project Member

Issue description

a few pixels from the bookmark bar are visible in full screen mode in linux.
 

Comment 1 by est...@chromium.org, Sep 20 2011

Labels: Merge-Requested

Comment 2 by bugdroid1@chromium.org, Sep 20 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=101920

------------------------------------------------------------------------
r101920 | estade@chromium.org | Mon Sep 19 22:37:47 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=101920&r2=101919&pathrev=101920

gtk: fix partially visible toolbar in fullscreen mode

BUG= 97177 
TEST=full screen linux chrome


Review URL: http://codereview.chromium.org/7966008
------------------------------------------------------------------------

Comment 3 by est...@chromium.org, Sep 20 2011

here is a screenshot of the issue (see the blue and grey lines at the top of the page)
fullscreen_bug.png
26.3 KB View Download

Comment 4 by kareng@google.com, Sep 22 2011

Labels: -Merge-Requested Merge-Approved

Comment 5 by bugdroid1@chromium.org, Oct 17 2011

Project Member
Labels: -merge-approved merge-merged-874
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105938

------------------------------------------------------------------------
r105938 | estade@chromium.org | Mon Oct 17 15:15:46 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=105938&r2=105937&pathrev=105938

Merge 101920 - gtk: fix partially visible toolbar in fullscreen mode

BUG= 97177 
TEST=full screen linux chrome


Review URL: http://codereview.chromium.org/7966008

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/8320019
------------------------------------------------------------------------

Comment 6 by est...@chromium.org, Oct 21 2011

Status: Fixed

Comment 7 by est...@chromium.org, Oct 28 2011

Labels: -Mstone-15 -merge-merged-874 Mstone-16 Merge-Requested
Status: Started
apparently still broken

Comment 8 by laforge@google.com, Oct 28 2011

Labels: -Merge-Requested Merge-Approved

Comment 9 by bugdroid1@chromium.org, Oct 31 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107999

------------------------------------------------------------------------
r107999 | estade@chromium.org | Mon Oct 31 13:12:13 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=107999&r2=107998&pathrev=107999
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc?r1=107999&r2=107998&pathrev=107999

gtk: fix more fullscreen bugs

1. hide/show titlebar widget when entering/exiting full screen
2. don't show bookmark bar when in fullscreen mode

BUG= 97177 
TEST=manual -- 1. Open new tab. 2. Full screen. 3. click on a link in the new tab page. 4. You shouldn't see a line at the top.

Review URL: http://codereview.chromium.org/8414014
------------------------------------------------------------------------

Comment 10 by bugdroid1@chromium.org, Nov 1 2011

Project Member
Labels: merge-merged-912
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=108043

------------------------------------------------------------------------
r108043 | estade@chromium.org | Mon Oct 31 17:12:15 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/912/src/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc?r1=108043&r2=108042&pathrev=108043
 M http://src.chromium.org/viewvc/chrome/branches/912/src/chrome/browser/ui/gtk/browser_window_gtk.cc?r1=108043&r2=108042&pathrev=108043

Merge 107999 - gtk: fix more fullscreen bugs

1. hide/show titlebar widget when entering/exiting full screen
2. don't show bookmark bar when in fullscreen mode

BUG= 97177 
TEST=manual -- 1. Open new tab. 2. Full screen. 3. click on a link in the new tab page. 4. You shouldn't see a line at the top.

Review URL: http://codereview.chromium.org/8414014

TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/8427023
------------------------------------------------------------------------

Comment 11 by vivianz@chromium.org, Nov 1 2011

Status: Fixed

Comment 12 by vivianz@chromium.org, Nov 1 2011

Status: Verified
verified as fixed in chrome 16.0.912.21 (Official Build 108057)

Comment 13 by k...@google.com, Jan 26 2012

Labels: -Merge-Approved Merge-Unknown
Moving to Unknown for merges in M16, as that ship has sailed.

Comment 14 by k...@google.com, Jan 26 2012

Labels: -Merge-Unknown
Remove unknown label on bugs that have a branch merged label.

Comment 15 by lukelett...@gmail.com, May 6 2012

Seems to still be there in Chrome 18.0.1025.168.  Seeing this on Ubuntu 11.04.

Comment 16 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 17 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Mstone-16 M-16 Cr-UI

Comment 18 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment