Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 17 users
Status: Verified
Owner:
Closed: May 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment
Disable web fonts by default
Reported by mal.chro...@gmail.com, Apr 2 2009 Back to list
Downloadable fonts have not passed security review. 

We should disable these by default (hide behind a --enable-web-fonts switch?) 
until the security review is passed.
 
Comment 1 by js...@chromium.org, Apr 7 2009
Hmm. disabling it will also break some layout tests. We also have to add a switch to
WebPreference and Settings (in WebCore). Perhaps, it's easier (quicker) to do it in
our copy of WebKit (in 2.0 branch) while leaving alone the trunk for now. 

OK, doing it on the branch is fine, but we'll need it on trunk soon too. We don't know 
how long it will be before we can come up with a safe solution to this problem.

For the layout tests, can we just disable/defer them on the branch? I assume that 
they'd all be tests for downloadable fonts, so they should be disabled if the feature 
is disabled.
Comment 3 by js...@chromium.org, Apr 16 2009
Labels: -OS-All OS-Windows
Status: Started
I have a working patch to add a cmd line switch and a preference entry.
Comment 4 by js...@chromium.org, Apr 21 2009
Mark, would you take my CLs and merge to the branch? They're at :

http://codereview.chromium.org/67209
http://codereview.chromium.org/67210

Or, if you prefer to have me make separate patches for the branch, I can do that, too. 

I can't check them in the trunk  until it's reviewed in the upstream. 
I'll get these merged to 172. Thanks.
Comment 6 by bugdro...@gmail.com, Apr 25 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=14519 

------------------------------------------------------------------------
r14519 | mal@chromium.org | 2009-04-24 23:30:41 -0700 (Fri, 24 Apr 2009) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/172/WebCore/css/CSSFontSelector.cpp?r1=14519&r2=14518
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/172/WebCore/page/Settings.cpp?r1=14519&r2=14518
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/172/WebCore/page/Settings.h?r1=14519&r2=14518

Disable web-fonts, WebKit side.

See also http://codereview.chromium.org/100012 for the Chrome side.

Add a flag to Settings to en/disable remote (web) font support in Webkit. 
(see also https://bugs.webkit.org/show_bug.cgi?id=25239)

This is the webkit part of the change. Chrome-part will be in a separate CL. 

BUG= 9633 
TBR=jshin
Review URL: http://codereview.chromium.org/99019
------------------------------------------------------------------------

Comment 7 by bugdro...@gmail.com, Apr 25 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=14520 

------------------------------------------------------------------------
r14520 | mal@chromium.org | 2009-04-24 23:32:24 -0700 (Fri, 24 Apr 2009) | 20 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/tab_contents/web_contents.cc?r1=14520&r2=14519
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/common/chrome_switches.cc?r1=14520&r2=14519
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/common/chrome_switches.h?r1=14520&r2=14519
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/common/render_messages.h?r1=14520&r2=14519
   M http://src.chromium.org/viewvc/chrome/branches/172/src/webkit/glue/webpreferences.h?r1=14520&r2=14519
   M http://src.chromium.org/viewvc/chrome/branches/172/src/webkit/glue/webview_impl.cc?r1=14520&r2=14519

Disable web-fonts, Chrome part.

This applies http://codereview.chromium.org/67210.
The patch is different on the 172 branch, so please review carefully.

The webkit part will be in another CL.

1. Adds '--enable-remote-font' command line switch
2. Adds a field ('enable_remote_font) to WebPreference
3. Pass the value of enable_remote_font to the corresponding field in
WebCore::Settings


TBR= jshin
BUG= 9633 
TEST: Run Chrome with and without '--enable-remote-font' command line flag and
go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page
should be rendered with 'dull-looking ordinary' fonts. With the flag, the page
should be rendered with 'decorative' remote fonts.
Review URL: http://codereview.chromium.org/100012
------------------------------------------------------------------------

Labels: -Mstone-2.0 Mstone-2.1
This is fixed for 2.0.

Moving to 2.1 for pending changes on trunk of Chromium/WebKit.
Comment 9 by xlyuan@chromium.org, Apr 30 2009
Verified on Beta channel build 2.0.172.13 (Official Build ), fixed; but leave the bug 
open as the reason mentioned in comment 8. 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=16169 

------------------------------------------------------------------------
r16169 | jungshik@google.com | 2009-05-15 12:23:18 -0700 (Fri, 15 May 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/WebKit/172/WebCore/css/CSSFontSelector.cpp?r1=16169&r2=16168

Enable SVG fonts regardless of whether remoteFontEnabled is on or not. 

BUG= 9633 
TEST= http://acid3.acidtests.org/  should get 100/100, with no  boxes in the upper right corner (still has the Linktest Failed error).


Review URL: http://codereview.chromium.org/113469
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=16247 

------------------------------------------------------------------------
r16247 | jshin@chromium.org | 2009-05-16 16:44:12 -0700 (Sat, 16 May 2009) | 14 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=16247&r2=16246
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=16247&r2=16246
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=16247&r2=16246
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=16247&r2=16246
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.h?r1=16247&r2=16246
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.cc?r1=16247&r2=16246

Chrome-part of disabling web fonts by default while still alowing SVG fonts

(The webkit part is http://codereview.chromium.org/67209/show and 
 http://bugs.webkit.org/show_bug.cgi?id=25239 )

1. Adds '--enable-remote-fonts' command line switch
2. Adds a field ('enable_remote_fonts) to WebPreference
3. Pass the value of enable_remote_fonts to the corresponding field in WebCore::Settings (m_downloadableBinaryFontsEnabled)

BUG= 9633 

TEST: 1. Run Chrome with and without '--enable-remote-font' command line flag and go to http://www.alistapart.com/d/cssatten/heid.html. Without the flag, the page should be rendered with 'dull-looking ordinary' fonts. With the flag, the page should be rendered with 'decorative' remote fonts.
2. Even without the above flag, Chrome should should get 100/100, with no  boxes in the upper right corner (still has the Linktest Failed error).
Review URL: http://codereview.chromium.org/67210
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=16250 

------------------------------------------------------------------------
r16250 | jshin@chromium.org | 2009-05-16 17:21:49 -0700 (Sat, 16 May 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell.cc?r1=16250&r2=16249

Set 'remote_fonts_enabled' to true in test_shell. Chrome has it off by default, but
we don't want to lose the test coverage for dynamic font support. So, we turn it on in test_shell.

TBR=darin
 http://crbug.com/9633 
TEST=The following two webkit tests pass:
  LayoutTests/fast/css/font-face-remote.html
  LayoutTests/fast/css/font-face-unicode-range.html

Review URL: http://codereview.chromium.org/115445
------------------------------------------------------------------------

Comment 13 by js...@chromium.org, May 17 2009
Labels: -Mstone-2.1 Mstone-2.0
Status: Fixed
Webkit  bug 25239  (http://bugs.webkit.org/show_bug.cgi?id=25239) was landed at long last 
!! And, we picked it up from the trunk. Our parts were just landed as well. 


Comment 14 by dhw@chromium.org, Jul 7 2009
 Issue 15694  has been merged into this issue.
Comment 15 by dhw@chromium.org, Jul 22 2009
 Issue 17418  has been merged into this issue.
Comment 16 by dhw@chromium.org, Jul 27 2009
 Issue 17776  has been merged into this issue.
Comment 17 by js...@chromium.org, Jul 27 2009
Status: Verified
Project Member Comment 18 by bugdroid1@chromium.org, Oct 12 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 19 by bugdroid1@chromium.org, Mar 11 2013
Labels: -Area-WebKit Cr-Content
Project Member Comment 20 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content Cr-Blink
Sign in to add a comment