New issue
Advanced search Search tips
Starred by 14 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 95454: Omnibox enters keyword search mode incorrectly

Reported by rsesek@chromium.org, Sep 6 2011 Project Member

Issue description

I'm not sure how I got myself into this state, but I can repro it every time and it feels very wrong.

What steps will reproduce the problem?
1. Type the word 'grow basil' in the Omnibox
2. The Omnibox enters keyword mode after typing the word 'grow' and that word is lost in the search; basil and subsequent words remain for the query.

The video may demonstrate this better. I type 'g' 'r' 'o' 'w' and then it immediately kicks into an old search.

What is the expected output? What do you see instead?
It should let me search for 'grow cilantro'.

Please use labels and text to provide additional information.
Chrome 15.0.865.0 dev on Mac 10.6.8.
 
broken-omnibox.mov
2.5 MB View Download

Comment 1 by rsesek@chromium.org, Sep 6 2011

Another datapoint: I've set google.com's keyword to just 'g' in the Manage Search Engines section of Preferences. I changed this to google.com and cannot reproduce it.

Comment 2 by sky@chromium.org, Sep 6 2011

Are you sure you don't have a keyword for 'grow'?
Extensions can also add keywords, and we don't surface that in the UI any where. Did you happen to install an extension that is causing this?
If none of the above, copy off your profile and I'll see if I can figure out where 'grow' is coming from.

Comment 3 by keishi@chromium.org, Sep 8 2011

Status: Started

Comment 4 by keishi@chromium.org, Sep 8 2011

 Issue 94477  has been merged into this issue.

Comment 5 by pkasting@chromium.org, Sep 12 2011

 Issue 96320  has been merged into this issue.

Comment 6 by bugdroid1@chromium.org, Sep 26 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=102688

------------------------------------------------------------------------
r102688 | keishi@chromium.org | Sun Sep 25 19:45:53 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc?r1=102688&r2=102687&pathrev=102688
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=102688&r2=102687&pathrev=102688
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_model.cc?r1=102688&r2=102687&pathrev=102688

Omnibox enters keyword search mode incorrectly

Happens when input starts with default search engine keyword.

BUG= 95454 
TEST=1. Set default search engine keyword to 'g'. 2. Type 'grand canyon' into omnibox. 3. Confirm that it is not in keyword search mode.


Review URL: http://codereview.chromium.org/7754008
------------------------------------------------------------------------

Comment 7 by rsesek@chromium.org, Sep 27 2011

 Issue 96963  has been merged into this issue.

Comment 8 by keishi@chromium.org, Sep 28 2011

Labels: Merge-Requested
Requesting merge to 15.

Comment 9 by pkasting@chromium.org, Sep 29 2011

 Issue 93814  has been merged into this issue.

Comment 10 by rsesek@chromium.org, Oct 6 2011

Labels: Mstone-15

Comment 11 by kareng@google.com, Oct 7 2011

Labels: -Merge-Requested Merge-Approved

Comment 12 by pkasting@chromium.org, Oct 7 2011

 Issue 98769  has been merged into this issue.

Comment 13 by pkasting@chromium.org, Oct 7 2011

Cc: pkasting@chromium.org
Issue 99491 has been merged into this issue.

Comment 14 by keishi@chromium.org, Oct 18 2011

Labels: -Merge-Approved Merge-Merged

Comment 15 by bugdroid1@chromium.org, Oct 18 2011

Project Member
Labels: merge-merged-874
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105989

------------------------------------------------------------------------
r105989 | keishi@chromium.org | Mon Oct 17 18:21:00 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc?r1=105989&r2=105988&pathrev=105989 (from /trunk/src/chrome/browser/autocomplete/autocomplete_popup_model_unittest.cc revision 102688)
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/chrome_tests.gypi?r1=105989&r2=105988&pathrev=105989
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/browser/autocomplete/autocomplete_popup_model.cc?r1=105989&r2=105988&pathrev=105989

Merge 102688 - Omnibox enters keyword search mode incorrectly

Happens when input starts with default search engine keyword.

BUG= 95454 
TEST=1. Set default search engine keyword to 'g'. 2. Type 'grand canyon' into omnibox. 3. Confirm that it is not in keyword search mode.


Review URL: http://codereview.chromium.org/7754008

TBR=keishi@chromium.org
Review URL: http://codereview.chromium.org/8329008
------------------------------------------------------------------------

Comment 16 by keishi@chromium.org, Oct 25 2011

Status: Fixed

Comment 17 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 18 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Feature-Omnibox -Mstone-15 Cr-UI Cr-UI-Browser-Omnibox M-15

Comment 19 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment