Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 94661 App and Extension with Same ID Confuse Sync
Starred by 1 user Reported by bolms@chromium.org, Aug 29 2011 Back to list
Status: Fixed
Owner: ----
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
1. Create an app.  Install in Chrome.
2. Enabled Sync.  Make sure the app is synced.
3. Publish an update to the app removing the "app" section from the manifest.
4. Update app to become extension.
5. Sync.

Ignoring some edge cases around app sync being enabled but not extension sync or vice versa, the app sync entry should be converted to an extension sync entry, and everything should continue working happily.

Instead, the browser crashes immediately during sync.

 
Comment 1 by bolms@chromium.org, Aug 29 2011
 Issue 94663  has been merged into this issue.
Comment 2 by bolms@chromium.org, Aug 30 2011
Labels: -Pri-2 Pri-3
Correction: this does not actually crash on M15 with no changes (I had a corrupt profile, causing a different crash during sync, related to history).

Further testing shows that we already filter out installs for the "wrong type", as well; there is a possibility for a zombie app or extension, but the author would have to #1: start with an app, #2: update it as an extension, #3: wait for the regular extension update process to update clients, then #4: update back to an app.  Any sync users who had uninstalled the extension between steps #3 and #4 would see the app suddenly return.  (And, of course, the steps also work if you start with an extension, update to app, then go back to extension.)

We should really change the "wrong" sync data into the "right" type, but there are also some issues around users who have chosen to sync apps or extensions, but not both.
Project Member Comment 3 by bugdroid1@chromium.org, Aug 30 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=98860

------------------------------------------------------------------------
r98860 | bolms@chromium.org | Tue Aug 30 12:35:06 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service_unittest.cc?r1=98860&r2=98859&pathrev=98860
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=98860&r2=98859&pathrev=98860

Fixing crash on sync when app becomes extension or vice versa.

BUG= 94661 
TEST=New unit test; also manually add a syncable app to profile, sync, then install extension with same ID: with change, no crash, without, crash on sync.


Review URL: http://codereview.chromium.org/7795011
------------------------------------------------------------------------
Comment 4 by bolms@chromium.org, Aug 30 2011
Status: Available
Status: Assigned
Is this still happening?
Labels: Mstone-19
Owner: mpcomplete@chromium.org
per triaging with aa@
Labels: -Mstone-19 Mstone-20
Punting since this is P3.
Comment 8 by k...@google.com, Apr 27 2012
Labels: -Mstone-20 Mstone-21 MovedFrom-20
We're too close to the branch point for any more Pri 3 bugs.  If you believe one of these needs to be in M20, please adjust the mstone and priority.
Comment 9 by karen@chromium.org, Jul 11 2012
Labels: -Mstone-21 MovedFrom-21 Mstone-22
Moving all non essential bugs to the next Milestone
Labels: -Mstone-22 Mstone-23
Comment 11 by karen@chromium.org, Oct 10 2012
Labels: -Mstone-23 MovedFrom-23 Mstone-24
Moving all non essential bugs to the next Milestone
Labels: -Mstone-24
Since the bug has moved few times, removing the milestone label. Please target the right milestone.
Project Member Comment 13 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Feature-Sync -Feature-Extensions -Feature-Apps -Area-UI Cr-Platform-Extensions Cr-Platform-Apps Cr-Services-Sync Cr-UI
Status: Available
I'm mass-declaring bug bankruptcy on extensions bugs. Unassigning myself as owner.
Owner: ----
Project Member Comment 16 by sheriffbot@chromium.org, Jun 23 2016
Labels: Hotlist-Recharge-Cold
Status: Untriaged
This issue has been available for more than 365 days, and should be re-evaluated. Hotlist-Recharge-Cold label is added for tracking. Please re-triage this issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed
I'm assuming this was fixed by #3.  There are probably still issues around this area, but those should/already do have their own bugs.
Sign in to add a comment