New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 68191
issue 68197

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 94468: testDownloadPercentage flakiness on Mac

Reported by nirnimesh@chromium.org, Aug 27 2011 Project Member

Issue description

The testDownloadPercentage test has recently been flaky on Mac. After downloading, the DownloadItem corresponding to this download is not 100%.


http://build.chromium.org/p/chromium.pyauto/builders/Mac%2010.5/builds/3880/steps/pyauto_functional_tests/logs/stdio

======================================================================
FAIL: downloads.DownloadsTest.testDownloadPercentage: "Verify that during downloading, % values increases,"
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/build/slave/Mac_10_5/build/src/chrome/test/functional/downloads.py", line 468, in testDownloadPercentage
    'Download percentage should be 100 after download completed')
AssertionError: Download percentage should be 100 after download completed

----------------------------------------------------------------------
 

Comment 1 by bugdroid1@chromium.org, Aug 27 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=98561

------------------------------------------------------------------------
r98561 | nirnimesh@chromium.org | Sat Aug 27 00:47:04 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/PYAUTO_TESTS?r1=98561&r2=98560&pathrev=98561

Disable testDownloadPercentage on Mac

TBR=dennisjeffrey@chromium.org
BUG= 94468 
TEST=

Review URL: http://codereview.chromium.org/7776003
------------------------------------------------------------------------

Comment 2 by nirnimesh@chromium.org, Aug 27 2011

Labels: pyauto

Comment 3 by mark@chromium.org, Aug 29 2011

Status: Available

Comment 4 by anan...@chromium.org, Sep 8 2011

Labels: -pyauto pyauto_tests
Owner: venkataramana@chromium.org

Comment 5 by anan...@chromium.org, Sep 8 2011

Status: Assigned

Comment 6 by rdsmith@chromium.org, Sep 14 2011

Blocking: 68197

Comment 7 by rdsmith@chromium.org, Sep 14 2011

Blocking: 68191

Comment 8 by rdsmith@chromium.org, Sep 22 2011

I believe I have a fix for this bug here: http://codereview.chromium.org/7966016/.  Venkataramana, any problem with me taking ownership?

Comment 9 by venkataramana@chromium.org, Sep 22 2011

Sure. Go ahead.

Thanks.

Comment 10 by bugdroid1@chromium.org, Sep 23 2011

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=102535

------------------------------------------------------------------------
r102535 | rdsmith@chromium.org | Fri Sep 23 11:27:08 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_item.cc?r1=102535&r2=102534&pathrev=102535
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/functional/PYAUTO_TESTS?r1=102535&r2=102534&pathrev=102535

Fix lack of initialization for delegate delayed complete flag.

BUG= 94468 
TEST=


Review URL: http://codereview.chromium.org/7966016
------------------------------------------------------------------------

Comment 11 by rdsmith@chromium.org, Sep 23 2011

Owner: rdsmith@chromium.org

Comment 12 by rdsmith@chromium.org, Sep 23 2011

Status: Fixed
This looks to be passing on the waterfalls now.

Comment 13 by bugdroid1@chromium.org, Oct 10 2011

Project Member
Labels: merge-merged-874
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=104811

------------------------------------------------------------------------
r104811 | rdsmith@chromium.org | Mon Oct 10 15:53:52 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/874/src/content/browser/download/download_item.cc?r1=104811&r2=104810&pathrev=104811
 M http://src.chromium.org/viewvc/chrome/branches/874/src/chrome/test/functional/PYAUTO_TESTS?r1=104811&r2=104810&pathrev=104811

Merge 102535 - Fix lack of initialization for delegate delayed complete flag.

BUG= 94468 
TEST=


Review URL: http://codereview.chromium.org/7966016

TBR=rdsmith@chromium.org
Review URL: http://codereview.chromium.org/8222020
------------------------------------------------------------------------

Comment 14 by rdsmith@chromium.org, Oct 11 2011

 Issue 99022  has been merged into this issue.

Comment 15 by rdsmith@chromium.org, Oct 11 2011

Cc: kareng@google.com
Labels: ReleaseBlock-Stable Mstone-15

Comment 16 by pavanv@chromium.org, Oct 11 2011

Status: Verified
Verified as fixed in 15.0.874.91 on Win7 and Mac OSX 10.6.8

No "circling" found in download status, LGTM.

Comment 17 by kareng@google.com, Oct 11 2011

Labels: Merge-Approved
wooot awesome! :) ty

Comment 18 by kareng@google.com, Oct 11 2011

Labels: -Merge-Approved Merge-Merged

Comment 20 by rdsmith@chromium.org, Jun 21 2012

Blocking: chromium:68191

Comment 21 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Blocking: -chromium:68197 -chromium:68191
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 22 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Area-UI -Feature-Downloads -Mstone-15 Cr-UI M-15 Cr-UI-Browser-Downloads

Comment 23 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment