New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Aug 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocked on:
issue nativeclient:2157

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Disable NaCl for 32-bit Linux on M14 release branch

Reported by cstefansen@google.com, Aug 16 2011

Issue description

We'll be requesting merge into the M14 for the CL for the Native Client issue http://code.google.com/p/nativeclient/issues/detail?id=2157 once it's ready.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=97285

------------------------------------------------------------------------
r97285 | elijahtaylor@google.com | Thu Aug 18 01:25:19 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=97285&r2=97284&pathrev=97285

Disable NaCl on 32-bit linux

BUG=  93165 
TEST= manual

Review URL: http://codereview.chromium.org/7670055
------------------------------------------------------------------------
Labels: Merge-Requested
Requesting merge for CL http://codereview.chromium.org/7670055.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=97323

------------------------------------------------------------------------
r97323 | ajwong@chromium.org | Thu Aug 18 10:01:14 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=97323&r2=97322&pathrev=97323

Revert 97285 - Disable NaCl on 32-bit linux

BUG=  93165 
TEST= manual

Review URL: http://codereview.chromium.org/7670055

TBR=elijahtaylor@google.com
Review URL: http://codereview.chromium.org/7624048
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 19 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=97440

------------------------------------------------------------------------
r97440 | elijahtaylor@google.com | Fri Aug 19 00:29:27 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_nacl_browsertest.cc?r1=97440&r2=97439&pathrev=97440
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=97440&r2=97439&pathrev=97440
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/native_client/test.html?r1=97440&r2=97439&pathrev=97440

Disable NaCl on 32-bit linux, also disable NaCl extension/store tests for that platform.

BUG= 93165 
TEST=manual

re-roll of http://codereview.chromium.org/7670055/, was reverted because tests weren't disabled.

Review URL: http://codereview.chromium.org/7621068
------------------------------------------------------------------------
Requesting merge for the new CL: http://codereview.chromium.org/7621068

Comment 6 by k...@google.com, Aug 21 2011

Labels: -Merge-Requested Merge-Approved
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2011

Labels: -merge-approved merge-merged-835
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=97688

------------------------------------------------------------------------
r97688 | elijahtaylor@google.com | Mon Aug 22 11:20:07 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/835/src/chrome/renderer/chrome_content_renderer_client.cc?r1=97688&r2=97687&pathrev=97688

Merge 97440 - Disable NaCl on 32-bit linux, also disable NaCl extension/store tests for that platform.

BUG= 93165 
TEST=manual

re-roll of http://codereview.chromium.org/7670055/, was reverted because tests weren't disabled.

Review URL: http://codereview.chromium.org/7621068

TBR=elijahtaylor@google.com
Review URL: http://codereview.chromium.org/7708011
------------------------------------------------------------------------

Comment 8 by k...@google.com, Aug 22 2011

Status: Fixed
Moving to fixed.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 13 2012

Blockedon: -nativeclient:2157 nativeclient:2157
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Mstone-14 -Feature-NaCl Cr-Platform-NaCl Cr-Internals M-14
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment