New issue
Advanced search Search tips
Starred by 5 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 910739



Sign in to add a comment
link

Issue 928954: Tab Hover Card Preview Images

Reported by dfried@chromium.org, Feb 6 Project Member

Issue description

Tracking bug for go/chrome-tab-hover-cards-design preview images.
 

Comment 1 by dfried@chromium.org, Feb 6

Status: Started (was: Untriaged)

Comment 2 by robliao@chromium.org, Feb 7

Labels: Group-Tab

Comment 4 by bugdroid, Feb 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6597261658f9a505605659b70306bddb4aad70e9

commit 6597261658f9a505605659b70306bddb4aad70e9
Author: Dana Fried <dfried@chromium.org>
Date: Mon Feb 11 20:16:59 2019

Placeholder preview image for hover cards (first pass).

Note: This is all behind a flag.

Still to do:
* Switch to og:image or screenshot instead of favicon where possible.
* Shrink bubble margins around the image to UX spec.
* Use more appealing image scaling mode.
* There is one frame of pop when the card switches to a new tab where
  the old image is still visible (this is a hover card rendering issue).

Bug: 928954
Change-Id: I86b7cf9af1fa7d5b64a884a3f39e12ec40b21457
Reviewed-on: https://chromium-review.googlesource.com/c/1459978
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630905}
[modify] https://crrev.com/6597261658f9a505605659b70306bddb4aad70e9/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.cc
[modify] https://crrev.com/6597261658f9a505605659b70306bddb4aad70e9/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.h

Comment 5 by bugdroid, Feb 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d5065fe18d3561eab838566debcd618f1e18f2

commit e9d5065fe18d3561eab838566debcd618f1e18f2
Author: Dana Fried <dfried@chromium.org>
Date: Wed Feb 13 02:06:59 2019

Fix tab hover card layout.

Hover card dimensions and spacing are now to spec.
Since we're still using placeholder favicon images, we're keeping them
(nearly) square and aligning them left; the final og:image and/or
screenshot will intsead fill the available space and be cropped or have
letterbox appropriately.

Correct behavior for pages with over-long titles will have to wait for
https://chromium-review.googlesource.com/c/chromium/src/+/1461829

Bug: 928954
Change-Id: Iff121f9924a3ba1572a788a9a1da70d619017474
Reviewed-on: https://chromium-review.googlesource.com/c/1462136
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631504}
[modify] https://crrev.com/e9d5065fe18d3561eab838566debcd618f1e18f2/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.cc

Sign in to add a comment