New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment
link

Issue 928378: Bookmark Folders and Find in Page have the same background and foreground colors when using Windows 10 Dark Mode

Reported by w...@charlesstover.com, Feb 4

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3693.0 Safari/537.36

Steps to reproduce the problem:
1. Change Windows 10 app mode from Light to Dark.

2a. Open a Bookmark
3a. It's difficult to read. Foreground is black. Background is dark gray.

2b. Ctrl-F
3b. type text
4b. It's completely unreadable.

What is the expected behavior?
the foreground and background to be different colors

What went wrong?
The foreground and background are the same color.

Did this work before? Yes 

Chrome version: 74.0.3693.0  Channel: canary
OS Version: 10.0
Flash Version: 

Windows 10 -> Settings -> Personalization -> Colors -> Choose your default app mode -> Dark

This causes Bookmarks folders to have a dark background, but it does not give them white text.

This causes Find in Page to have white text, but it does not give it a dark background.
 
ctrl-f.png
3.4 KB View Download
bookmarks-folder.png
5.5 KB View Download

Comment 1 by robliao@chromium.org, Feb 4

Labels: Hotlist-DesktopUIConsider Group-Dark_Mode
Status: Untriaged (was: Unconfirmed)

Comment 2 by robliao@chromium.org, Feb 6

Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged Target-74
Owner: robliao@chromium.org
Status: Started (was: Untriaged)

Comment 3 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f1e071626288333c68895d9389f28630cc016ba

commit 6f1e071626288333c68895d9389f28630cc016ba
Author: Robert Liao <robliao@chromium.org>
Date: Wed Feb 06 12:50:36 2019

Add kColorId_EnabledMenuItemForegroundColor to the Common Theme Aura Dark Mode List

Menus on Windows use the Aura colors.

BUG= 928378 

Change-Id: Ib49917e4902f06e2423048a07bea4447e07ecf10
Reviewed-on: https://chromium-review.googlesource.com/c/1455625
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629544}
[modify] https://crrev.com/6f1e071626288333c68895d9389f28630cc016ba/ui/native_theme/common_theme.cc

Comment 4 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1a2b3e0baab668bc18a9e8756fbadbb4f78d0a

commit 5c1a2b3e0baab668bc18a9e8756fbadbb4f78d0a
Author: Robert Liao <robliao@chromium.org>
Date: Wed Feb 06 16:43:42 2019

Route Dark Mode Windows Colors through GetAuraColor()

Win32 system colors currently don't support Dark Mode. As a result,
fallback on the Aura colors. Inverted color schemes can be ignored here
as it's only true when Chrome is running on a high-contrast AND when
the relative luminance of COLOR_WINDOWTEXT is greater than COLOR_WINDOW
(e.g. white on black), which is basically like dark mode.

BUG= 928378 

Change-Id: I71ae0c1dd13213278461c04f50ae8ae8e5599a87
Reviewed-on: https://chromium-review.googlesource.com/c/1455646
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629610}
[modify] https://crrev.com/5c1a2b3e0baab668bc18a9e8756fbadbb4f78d0a/ui/native_theme/native_theme_win.cc

Comment 5 by robliao@chromium.org, Feb 8

Status: Fixed (was: Started)

Comment 6 by robliao@chromium.org, Feb 8

Issue 929047 has been merged into this issue.
Cc: swarnasree.mukkala@chromium.org
Labels: Needs-Feedback
Tried testing the issue on the reported chrome version #74.0.3693.0 and latest chrome #74.0.3699.0 by following below steps.

Unable to achieve dark mode with the setting "Windows 10 -> Settings -> Personalization -> Colors -> Choose your default app mode -> Dark". Hence, launched chrome through the terminal with "--force-dark-mode".
Able to reproduce the issue on the reported chrome version(#74.0.3693.0) and fix on latest M-74(74.0.3699.0) by following steps as per comment#0 using Window 10.
Attached screenshots for reference.

@Robert Liao: Could you please review attached screenshots and let us know if anything is missed from our end, help us in verifying the fix on latest M-74.
Thanks.!
928378_Bookmarks.png
403 KB View Download
928378_Ctrl+F.png
391 KB View Download

Comment 8 by robliao@chromium.org, Feb 8

The screenshots suggest that the issue is fixed with light text on a dark background.

Sign in to add a comment