New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 92644 link

Starred by 6 users

Issue metadata

Status: Duplicate
Merged: issue 111049
Owner:
OOO until 4th
Closed: Jan 2012
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Add `content_security_policy` to sample/example extensions when relevant.

Project Member Reported by mkwst@chromium.org, Aug 12 2011

Issue description

Generally speaking, extension authors would be better off using `"content_security_policy": "default-src 'self'"`. I think it would be worthwhile to add that attribute to each of our sample extensions, where it makes sense. Probably worthwhile to add to our tests too, as I find myself sifting through those when I need usage info.
 

Comment 1 by tsepez@chromium.org, Aug 12 2011

Cc: tsepez@chromium.org abarth@chromium.org
Labels: -Type-Bug

Comment 2 by mkwst@chromium.org, Aug 12 2011

I've CCd you both on http://codereview.chromium.org/7633017/ where I've made a tentative, untested first pass. If we decide that this makes sense to do, I'll start testing things. :)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 14 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105542

------------------------------------------------------------------------
r105542 | mkwst@chromium.org | Fri Oct 14 12:33:43 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/proxy_configuration/popup.css?r1=105542&r2=105541&pathrev=105542
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/proxy_configuration.zip?r1=105542&r2=105541&pathrev=105542
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/proxy_configuration/popup.js?r1=105542&r2=105541&pathrev=105542
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/proxy_configuration/popup.html?r1=105542&r2=105541&pathrev=105542
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=105542&r2=105541&pathrev=105542
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/proxy_configuration/manifest.json?r1=105542&r2=105541&pathrev=105542
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/proxy_configuration/background.js?r1=105542&r2=105541&pathrev=105542
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.html?r1=105542&r2=105541&pathrev=105542
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/proxy_configuration/background.html?r1=105542&r2=105541&pathrev=105542

Adding `content_security_policy` to proxy sample extension.

BUG= 92644 
TEST=

Review URL: http://codereview.chromium.org/8273036
------------------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=105725

------------------------------------------------------------------------
r105725 | mkwst@chromium.org | Sun Oct 16 01:45:29 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/imageinfo/info.js?r1=105725&r2=105724&pathrev=105725
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/imageinfo/background.js?r1=105725&r2=105724&pathrev=105725
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/imageinfo/background.html?r1=105725&r2=105724&pathrev=105725
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/imageinfo/info.html?r1=105725&r2=105724&pathrev=105725
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/imageinfo.zip?r1=105725&r2=105724&pathrev=105725
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=105725&r2=105724&pathrev=105725
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/imageinfo/info.css?r1=105725&r2=105724&pathrev=105725
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.html?r1=105725&r2=105724&pathrev=105725
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/imageinfo/manifest.json?r1=105725&r2=105724&pathrev=105725

Adding `content_security_policy` to imageinfo extension.

BUG= 92644 
TEST=

Review URL: http://codereview.chromium.org/8310002
------------------------------------------------------------------------
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106043

------------------------------------------------------------------------
r106043 | mkwst@chromium.org | Tue Oct 18 01:42:56 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/mappy_content_script.js?r1=106043&r2=106042&pathrev=106043
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/popup.css?r1=106043&r2=106042&pathrev=106043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy.zip?r1=106043&r2=106042&pathrev=106043
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/popup.js?r1=106043&r2=106042&pathrev=106043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/popup.html?r1=106043&r2=106042&pathrev=106043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=106043&r2=106042&pathrev=106043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/manifest.json?r1=106043&r2=106042&pathrev=106043
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/background.js?r1=106043&r2=106042&pathrev=106043 (from /trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/background.html revision 106042)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.html?r1=106043&r2=106042&pathrev=106043
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy/background.html?r1=106043&r2=106042&pathrev=106043

Adding `content_security_policy` to the "Mappy" sample.

This involved pretty much rewriting the popup code to avoid a script injected
via `document.write` in the Maps API code.

BUG= 92644 
TEST=

Review URL: http://codereview.chromium.org/8311007
------------------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=106059

------------------------------------------------------------------------
r106059 | mkwst@chromium.org | Tue Oct 18 06:47:31 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.html?r1=106059&r2=106058&pathrev=106059
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.js?r1=106059&r2=106058&pathrev=106059 (from /trunk/src/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html revision 106058)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/manifest.json?r1=106059&r2=106058&pathrev=106059
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html?r1=106059&r2=106058&pathrev=106059
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/mappy.zip?r1=106059&r2=106058&pathrev=106059
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.css?r1=106059&r2=106058&pathrev=106059
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/enableReferrer.zip?r1=106059&r2=106058&pathrev=106059
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=106059&r2=106058&pathrev=106059
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.html?r1=106059&r2=106058&pathrev=106059
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.js?r1=106059&r2=106058&pathrev=106059 (from /trunk/src/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html revision 106058)
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies/popup.css?r1=106059&r2=106058&pathrev=106059
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/allowThirdPartyCookies.zip?r1=106059&r2=106058&pathrev=106059
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/manifest.json?r1=106059&r2=106058&pathrev=106059

Samples for `enableReferrer` and `allowThirdPartyCookies` should use the `privacy` namespace.

While fixing these samples, I've also added `content_security_policy` as a
drive-by.

BUG= 92644 
TEST=

Review URL: http://codereview.chromium.org/8341010
------------------------------------------------------------------------
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107084

------------------------------------------------------------------------
r107084 | mkwst@chromium.org | Tue Oct 25 02:25:46 PDT 2011

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications/style.css?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications/manifest.json?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications/background.js?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y.zip?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/popup.js?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/howto/contentscript_xhr/contentscript.js?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/app_launcher/popup.js?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y/manifest.json?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/howto/contentscript_xhr.zip?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp.zip?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y/feed_iframe.js?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y/feed.css?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/contentSettings.zip?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url/background.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path.zip?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/manifest.json?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/background.js?r1=107084&r2=107083&pathrev=107084 (from /trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/background.html revision 107080)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/contentSettings/manifest.json?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/manifest.json?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/background.js?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/contentSettings/popup.js?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y/feed.js?r1=107084&r2=107083&pathrev=107084 (from /trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y/feed.html revision 107080)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/devtools.js?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/omnibox/extension-docs/background.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications/options.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/app_launcher/popup.css?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/app_launcher.zip?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications/background.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/extension/isAllowedAccess.zip?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/popup.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url.zip?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/app_launcher/manifest.json?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/app_launcher/popup.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/extension/isAllowedAccess/manifest.json?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url/manifest.json?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/pageAction/pageaction_by_url/background.js?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/contextMenus/basic.zip?r1=107084&r2=107083&pathrev=107084
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications/error.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/omnibox/extension-docs.zip?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/background.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/contextMenus/basic/manifest.json?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/set_icon_path/background.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/omnibox/extension-docs/manifest.json?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications.zip?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y/feed_iframe.css?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/contentSettings/popup.html?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/omnibox/extension-docs/background.js?r1=107084&r2=107083&pathrev=107084
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/notifications/options.js?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/news_a11y/feed.html?r1=107084&r2=107083&pathrev=107084
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp/devtools.html?r1=107084&r2=107083&pathrev=107084

Adding `content_security_policy` to 10 sample extensions.

Touched:
* contentSettings
* contextMenus/basic
* browserAction/set_icon_path
* app_launcher
* devtools/network/chrome-firephp
* extension/isAllowedAccess
* news_a11y
* notifications
* omnibox/extension-docs
* pageAction/pageaction_by_url

As a drive-by, fixed the broken `contentscript_xhr` by changing to Twitter's
new API endpoint

BUG= 92644 
TEST=

Review URL: http://codereview.chromium.org/8309001
------------------------------------------------------------------------
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 25 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=107094

------------------------------------------------------------------------
r107094 | mkwst@chromium.org | Tue Oct 25 03:32:32 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/webNavigation/basic/manifest.json?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/webNavigation/basic/background.js?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/windows/merge_windows.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/windows/merge_windows/manifest.json?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.js?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/windows/merge_windows/background.js?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.html?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp.zip?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/webNavigation/basic/popup.js?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/ttsdebug/ttsdebug.css?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/background.html?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/ttsdebug/ttsdebug.js?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/manifest.json?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/screenshot.html?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.js?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.css?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/app_launcher.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/processes/show_tabs.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/webNavigation/basic/background.html?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/ttsdebug.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/processes/show_tabs/manifest.json?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/ttsdebug/manifest.json?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/processes/show_tabs/popup.html?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/windows/merge_windows/background.html?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/manifest.json?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/background.js?r1=107094&r2=107093&pathrev=107094 (from /trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/screenshot.js revision 107085)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/webNavigation/basic/popup.html?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/omnibox/extension-docs.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/tabs/screenshot/screenshot.js?r1=107094&r2=107093&pathrev=107094
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/webNavigation/basic/popup.css?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/extensions/ttsdebug/ttsdebug.html?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/webNavigation/basic.zip?r1=107094&r2=107093&pathrev=107094
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/browserAction/make_page_red/background.html?r1=107094&r2=107093&pathrev=107094

Adding `content_security_policy` to 5 sample extensions

Touched:
* tabs/screenshot
* webNavigation/basic
* windows/merge_windows
* browserAction/make_page_red
* extensions/ttsdebug

BUG= 92644 
TEST=

Review URL: http://codereview.chromium.org/8318001
------------------------------------------------------------------------
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 25 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=111588

------------------------------------------------------------------------
r111588 | mkwst@chromium.org | Fri Nov 25 03:19:28 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/speechInput/basic/manifest.json?r1=111588&r2=111587&pathrev=111588
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/speechInput/basic/background.js?r1=111588&r2=111587&pathrev=111588 (from /trunk/src/chrome/common/extensions/docs/examples/api/speechInput/basic/background.html revision 111577)
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/speechInput/basic/background.html?r1=111588&r2=111587&pathrev=111588
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.json?r1=111588&r2=111587&pathrev=111588
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/examples/api/speechInput/basic.zip?r1=111588&r2=111587&pathrev=111588
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/experimental.settings.html?r1=111588&r2=111587&pathrev=111588
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/samples.html?r1=111588&r2=111587&pathrev=111588

Adding `content_security_policy` to Speech Input API sample.

As a drive-by, this CL also regenerates the `experimental.settings` docs, which someone apparently forgot to do after committing. :)

BUG= 92644 
TEST=

Review URL: http://codereview.chromium.org/8698003
------------------------------------------------------------------------

Comment 10 by mkwst@chromium.org, Jan 23 2012

Mergedinto: 111049
Status: Duplicate
Deprecating this bug in favor of  Issue #111049  where we're adding `manifest_version` 2 to all the samples. More or less the same task, but less CSP-specific.
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
Mergedinto: chromium:111049
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Feature-Extensions Cr-Platform-Extensions

Sign in to add a comment