Window maximize tests are failing on Waterfall ChromeDriver builder for Mac platform |
||||
Issue descriptionWindow maximize tests are failing on Waterfall ChromeDriver builder for Mac platform: https://ci.chromium.org/buildbot/chromium.chromedriver/Mac%2010.6/ Changes committed by CL r624785 are causing these tests to fail. This is blocking building ChromeDriver for Mac platform. What steps will reproduce the problem? 1. In 'chromium' project build chrome and chromedriver targets, e.g., autoninja -C out/Default chrome chromedriver 2. Run the following command: python chrome/test/chromedriver/test/run_java_tests.py --chrome=out/Default/chrome --chromedriver=out/Default/chromedriver --filter=WindowTest.testCanMaximizeTheWindowFromFrame
,
Today
(6 hours ago)
,
Today
(5 hours ago)
We are running Selenium Java tests for ChromeDriver and for these particular tests ChromeDriver gets the following minimum size in DevTools response:
...
[junit] [1548202501.426][INFO]: [7a29b24ed4e664a6f8202a299a6308a7] RESPONSE GetWindowSize {
[junit] "height": 300,
[junit] "width": 640
[junit] }
...
Selenium Java tests by design are trying to set the window size to 640 x 275, and because of 275 for the height is less than the minimum window height (300), that is why test fails.
We could make changes in our tests to conform to the window minimum sizes returned by DevTools.
,
Today
(4 hours ago)
We changed the tests so they are now passing. Checked on Linux and Mac platforms.
,
Today
(4 hours ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by khachatryan@chromium.org
, Today (6 hours ago)