Incorrect cpplint header_guard warning |
||
Issue descriptionExample: https://chromium-review.googlesource.com/c/chromium/src/+/1427926/4/chrome/browser/ui/ash/accessibility/fake_accessibility_controller.h#5 The suggested header guards are like: _B_S_W_IR_CHROME_BROWSER_UI_ASH_ACCESSIBILITY_FAKE_ACCESSIBILITY_CONTROLLER_H_ when they should be like CHROME_BROWSER_UI_ASH_ACCESSIBILITY_FAKE_ACCESSIBILITY_CONTROLLER_H_
,
Today
(6 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90acfd264e65dc445527a1ad405871fd027f4754 commit 90acfd264e65dc445527a1ad405871fd027f4754 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Jan 22 23:26:35 2019 [tricium cpplint] Disable build/header_guard and runtime/explicit in src The build/header_guard isn't working for the cpplint analyzer right now, which is creating a lot of noise. Disabling runtime/explicit for now because of discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1415258. TBR=maruel TBR_REASON=this is a small config change that should be committed quickly because it fixes an issue that is creating noise for many people. Bug: 924326 Change-Id: Ie904b445cf0babc9f2a61ae5f62734f0b5402d0d Reviewed-on: https://chromium-review.googlesource.com/c/1427932 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#624984} [modify] https://crrev.com/90acfd264e65dc445527a1ad405871fd027f4754/infra/config/global/tricium-prod.cfg
,
Today
(6 hours ago)
,
Today
(5 hours ago)
Note, in theory this shouldn't affect chromium/src anymore. In recent patchsets of recent CLs it appears to not appear anymore, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1419014/6/chrome/browser/chromeos/accessibility/fake_accessibility_focus_ring_controller.h. It would still be useful to be able to reenable the header_guard warning though, so I'd like to keep this bug open to investigate why it's happening. Reproduced in test CL https://chromium-review.googlesource.com/c/playground/gerrit-tricium/+/1412933; example run for that CL https://chromium-swarm.appspot.com/task?id=4290cfaf91843610&refresh=10&show_raw=1. Hypothesis 1: cpplint can't find the correct root because it looks for the root starting from cwd of the invoking analyzer process, *not* starting from the files being linted. |
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Today (7 hours ago)