New issue
Advanced search Search tips

Issue 924305 link

Starred by 1 user
Status: Assigned
Owner:
osh...@chromium.org
Cc:
msw@chromium.org
jamescook@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Chrome OS: --show-taps window is too small; only paints circles in upper left

Project Member Reported by msw@chromium.org, Today (8 hours ago) 
Chrome OS: --show-taps window is too small; only paints circles in upper left

On a linux-chromeos debug build on ToT @ #624881
1. Run "xinput list" to get the id of a mouse to simulate touch (8).
2. Run "chrome --touch-devices=8 --show-taps"
3. Use the mouse to simulate touch tapping in various places.
Expected: visual feedback is provided for taps anywhere on the screen
Actual: visual feedback is clipped to a rect in the upper-left of the screen

Resizing the ash-host-display window seems to fix the issue for that session.

A bisect yielded "622488 (known good)" and "622511 (first known bad)" with changelog:
  https://chromium.googlesource.com/chromium/src/+log/2b32f46e421683240c8cede7069940cc909c2145..44972d384a132962c1bdddafccc5b6cdf073bf35

Reverting this WindowState change seems to fix this issue:
  https://chromium.googlesource.com/chromium/src/+/44972d384a132962c1bdddafccc5b6cdf073bf35

Oshima, can you please take a look? Let me or James know if you don't have cycles, thanks.
show_taps_small_window.png
17.4 KB View Download

Comment 1 by jamescook@chromium.org, Today (7 hours ago)

Labels: M-73
oshima, just FYI, "show taps" runs as an out-of-process mojo app, using the window service mojo APIs. It creates a transparent fullscreen window. Code is in //ash/components/tap_visualizer

I think it uses the code path in //ash/wm/non_client_frame_controller.cc to configure an ash-side proxy widget. Maybe there's a window in that code path that needs to have a WindowState, or maybe WindowState doesn't correctly deal with these sorts of windows.
►

Sign in to add a comment