New issue
Advanced search Search tips

Issue 924298 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

HistoryTabHelper::DidFinishNavigation has dead code

Project Member Reported by eugene...@chromium.org, Today (8 hours ago)

Issue description

const bool hidden =
      navigation_context->GetError() ||
      (navigation_context->GetResponseHeaders() &&
       navigation_context->GetResponseHeaders()->response_code() >= 400 &&
       navigation_context->GetResponseHeaders()->response_code() > 600) ||
      !ui::PageTransitionIsMainFrame(navigation_context->GetPageTransition());

1.) navigation_context->GetError() can never return error, because HistoryTabHelper::DidFinishNavigation early returns on error.

2.) ui::PageTransitionIsMainFrame can never return false, because HistoryTabHelper::DidFinishNavigation is not called for iframes.
 

Sign in to add a comment