New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 924295 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 924310



Sign in to add a comment

VaapiJpegDecodeAccelerator::OutputPicture() should early out if it can't convert to I420

Project Member Reported by andrescj@chromium.org, Today (8 hours ago)

Issue description

See [1]. Right now, it would notify the client that the video frame is ready, which is not true.

[1] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc?l=414-416&rcl=95a1e24688c9a29ce5aea56f17d45e5ccd0e409e
 

Comment 1 by andrescj@chromium.org, Today (7 hours ago)

Blocking: 924310
Project Member

Comment 2 by bugdroid, Today (7 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/441042454df0102f1194e04ffda617a8387823f9

commit 441042454df0102f1194e04ffda617a8387823f9
Author: Andres Calderon Jaramillo <andrescj@chromium.org>
Date: Tue Jan 22 22:22:17 2019

VAAPI-JDA: OutputPicture should fail if I420 conversion fails.

This CL makes VaapiJpegDecodeAccelerator::OutputPicture() return early
if it's not possible to convert the image to I420 format. Otherwise, it
would be wrongly notifying the client of success in this case.

Bug:  924295 
Test: JDA unit tests pass on an eve.
Change-Id: I57f558e2e0061ceef93600a9c373596150035fa5
Reviewed-on: https://chromium-review.googlesource.com/c/1427880
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624962}
[modify] https://crrev.com/441042454df0102f1194e04ffda617a8387823f9/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc

Comment 3 by andrescj@chromium.org, Today (7 hours ago)

Status: Fixed (was: Assigned)

Sign in to add a comment