Auto-commit should wait until all OWNERS approvals are granted |
|
Issue descriptionBug 631551 implemented an auto-commit mechanism for Chromium CLs (which is lovely, thank you!). This is a follow-up feature request: It's common for Chromium CLs to need approval from multiple reviewers – quite often, due to the need for OWNERS approval for changes to different parts of the codebase. Currently, CLs that require multiple owners' approval set CQ+2 on each reviewer's CR+1. Gerrit should instead do something more like Critique, which waits until all necessary approvals are granted. Example CL where this was an issue: https://chromium-review.googlesource.com/c/chromium/src/+/1425562 For some more context, see https://bugs.chromium.org/p/chromium/issues/detail?id=631551#c75 |
|
►
Sign in to add a comment |
|
Comment 1 by isherman@chromium.org
, Today (8 hours ago)