New issue
Advanced search Search tips

Issue 924291 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Auto-commit should wait until all OWNERS approvals are granted

Project Member Reported by isherman@chromium.org, Today (8 hours ago)

Issue description

 Bug 631551  implemented an auto-commit mechanism for Chromium CLs (which is lovely, thank you!). This is a follow-up feature request:

It's common for Chromium CLs to need approval from multiple reviewers – quite often, due to the need for OWNERS approval for changes to different parts of the codebase. Currently, CLs that require multiple owners' approval set CQ+2 on each reviewer's CR+1. Gerrit should instead do something more like Critique, which waits until all necessary approvals are granted.

Example CL where this was an issue: https://chromium-review.googlesource.com/c/chromium/src/+/1425562

For some more context, see https://bugs.chromium.org/p/chromium/issues/detail?id=631551#c75
 

Comment 1 by isherman@chromium.org, Today (8 hours ago)

Cc: tandrii@chromium.org

Sign in to add a comment