New issue
Advanced search Search tips

Issue 924250 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update SyncTest to not use GetURLRequestContext

Project Member Reported by rmcelrath@google.com, Today (10 hours ago)

Issue description

SyncTest currently creates a jingle_glue::NetworkServiceConfigTestUtil, which requires a URLRequestContextGetter. This causes tests based on this to fail when run with the network service enabled.

The following tests fail (all in the sync_integration_tests suite):
-MigrationSingleClientTest.AllTypesAtOnce
-MigrationSingleClientTest.AllTypesAtOnceTriggerNotification
-MigrationSingleClientTest.AllTypesWithNigoriAtOnce
-MigrationSingleClientTest.BookmarksPrefsBoth
-MigrationSingleClientTest.BookmarksPrefsIndividually
-MigrationSingleClientTest.NigoriOnly
-MigrationSingleClientTest.PrefsNigoriBoth
-MigrationSingleClientTest.PrefsOnlyModifyBookmark
-MigrationSingleClientTest.PrefsOnlyModifyPref
-MigrationSingleClientTest.PrefsOnlyTriggerNotification
-SyncExponentialBackoffTest.OfflineToOnline

With the following stacktrace:
[13960:13960:0116/163953.746897:FATAL:storage_partition_impl.cc(772)] Check failed: false.
  #0 0x55f0b62f467f base::debug::StackTrace::StackTrace()
  #1 0x55f0b6255e8a logging::LogMessage::~LogMessage()
  #2 0x55f0b4375da1 content::StoragePartitionImpl::GetURLRequestContext()
  #3 0x55f0b60fc1c7 (anonymous namespace)::BuildP2PProfileInvalidationProvider()
  #4 0x55f0b60f9343 (anonymous namespace)::BuildSelfNotifyingP2PProfileInvalidationProvider()
  #5 0x55f0b3496a42 base::internal::Invoker<>::Run()
  #6 0x55f0b884fc91 base::internal::Invoker<>::Run()
  #7 0x55f0b79c5d59 KeyedServiceFactory::GetServiceForContext()
  #8 0x55f0b79c5b4b KeyedServiceFactory::SetTestingFactoryAndUse()
  #9 0x55f0b884fab3 BrowserContextKeyedServiceFactory::SetTestingFactoryAndUse()
  #10 0x55f0b60f8cf3 SyncTest::SetUpInvalidations()
  #11 0x55f0b60f6f0b SyncTest::InitializeProfile()
  #12 0x55f0b60fc64c (anonymous namespace)::SyncProfileDelegate::OnProfileCreated()
  #13 0x55f0b662cada ProfileImpl::DoFinalInit()
  #14 0x55f0b662e7e6 ProfileImpl::OnLocaleReady()
  #15 0x55f0b662c039 ProfileImpl::OnPrefsLoaded()
  #16 0x55f0b662bd1b ProfileImpl::ProfileImpl()
  #17 0x55f0b6629d67 Profile::CreateProfile()
  #18 0x55f0b60f74e9 SyncTest::MakeTestProfile()
  #19 0x55f0b60f6d53 SyncTest::CreateProfile()
  #20 0x55f0b60f89e9 SyncTest::SetupClients()
  #21 0x55f0b2d5b189 (anonymous namespace)::MigrationSingleClientTest_AllTypesAtOnce_Test::RunTestOnMainThread()
 

Comment 1 by rmcelrath@google.com, Today (6 hours ago)

Labels: Proj-Servicification Proj-Servicification-Beta

Comment 2 by rmcelrath@google.com, Today (6 hours ago)

Labels: -Proj-Servicification-Beta Proj-Servicification-Canary

Sign in to add a comment