New issue
Advanced search Search tips

Issue 924242 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature

Blocking:
issue 922400



Sign in to add a comment

Java EmbeddedTestServer should support ClientCertType

Project Member Reported by ntfschr@chromium.org, Today (10 hours ago)

Issue description

See issue 922400 for motivation.

We need to configure ClientCertType from Java in order to properly test WebView's onReceivedSslError/onReceivedError callbacks.

Although I only need ClientCertType to write the tests I want, I propose we implement a bare-bones SSLServerConfig Java class (which we'll use to build the native one [1]), which will only have the ClientCertType member:

 * Although we only need one option right now, other options may be useful in the future.
 * Exposing ClientCertType as yet another int param makes it hard to disambiguate between "default ClientCertType and custom port" and "custom ClientCertType and default port"

The initial implementation would only include ClientCertType, and would deconstruct SSLServerConfig to pass over aidl/jni. This has the nice benefit that each future addition to SSLServerConfig must go through another security review (per the OWNERS rules).

---

Paul, do you have any objection to this plan? Or, do know of any other SSLServerConfig members I should implement at the same time?

[1] https://cs.chromium.org/chromium/src/net/ssl/ssl_server_config.h?l=20&rcl=4caa328720e40e61dbee085f45d49ba2c3cb8640
 

Sign in to add a comment