New issue
Advanced search Search tips

Issue 924232 link

Starred by 2 users
Status: Assigned
Owner:
weili@chromium.org
Cc:
pbos@chromium.org
robliao@chromium.org
ellyjo...@chromium.org
pkasting@chromium.org
bettes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Use focus ring instead of ink drop for native buttons keyboard focus on all platforms

Project Member Reported by weili@chromium.org, Today (10 hours ago) 
OS: Windows, Linux, and ChromeOS

What steps will reproduce the problem?
(1) Use keyboard to focus on toolbar or bookmark area
(2) Navigate thru bookmark buttons or toolbar buttons using keyboard
(3) the keyboard focus shows as ink drop other than focus ring

My proposal:
Use focus ring instead of ink drop for keyboard focus

Reasons:
1) Avoid contrast bugs like 864642;
2) Consistent across platforms: We uses focus ring for these on Mac now.
3) UI consistency: Tab strip and omnibox are using focus ring already.

Comment 1 by pbos@chromium.org, Today (10 hours ago) 

Conceptually this should be changing:

const bool PlatformStyle::kPreferFocusRings = false;

+ cleanup (probably including removing this flag), but you'll also likely run into changes where we have implicit expections on platform -> style. I expect those to be few.

Also huge thanks for doing this.
►

Sign in to add a comment