New issue
Advanced search Search tips

Issue 924171 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 924093



Sign in to add a comment

AutofillMetricsTest tests cannot run one after another

Project Member Reported by olivierrobin@chromium.org, Today (12 hours ago)

Issue description

There is a conflict between 
AutofillMetricsTest.AddressSuggestionsCount
and
AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions

which make them fail if they run one after the other.

AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/0 tests that "Autofill.AddressSuggestionsCount" does not exist in StatisticsRecorder but it is created by AutofillMetricsTest.AddressSuggestionsCount

You can reproduce by running

components_unittests --gtest_filter="*AutofillMetricsTest.AddressSuggestionsCount*:AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestion*"

in single process

 

Comment 1 by olivierrobin@chromium.org, Today (12 hours ago)

Summary: AutofillMetricsTest tests cannot run one after another (was: AutofillMetricsTest cannot run one after another)

Comment 2 by olivierrobin@chromium.org, Today (12 hours ago)

log of 
./components_unittests --gtest_filter="*AutofillMetricsTest.AddressSuggestionsCount*:AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestion*"

[==========] Running 3 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from AutofillMetricsTest
[ RUN      ] AutofillMetricsTest.AddressSuggestionsCount

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8893804e40)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8893804e40)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8893804e40)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8893804e40)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8893804e40)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[       OK ] AutofillMetricsTest.AddressSuggestionsCount (48 ms)
[----------] 1 test from AutofillMetricsTest (51 ms total)

[----------] 2 tests from AutofillMetricsTest/AutofillMetricsCompanyTest
[ RUN      ] AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/0

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: OnGetAutocompleteSuggestions(0, true, false, @0x7ffeed4276f8 company, @0x7ffeed427758 , @0x7ffeed427770 "text", 16-byte object <70-A7 9D-91 88-7F 00-00 40-52 00-92 88-7F 00-00>)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
../../components/autofill/core/browser/autofill_metrics_unittest.cc:3011: Failure
Expected equality of these values:
  nullptr
    Which is: NULL
  base::StatisticsRecorder::FindHistogram( "Autofill.AddressSuggestionsCount")
    Which is: 0x7f8894a89870
Stack trace:
0   libbase.dylib                       0x00000001282f0cf5 base::debug::StackTrace::StackTrace() + 37
1   components_unittests                0x0000000106196d2a StackTraceGetter::CurrentStackTrace(int, int) + 90
2   components_unittests                0x00000001061a6087 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71
3   components_unittests                0x00000001061a5b61 testing::internal::AssertHelper::operator=(testing::Message const&) const + 145
4   components_unittests                0x0000000102a985c6 autofill::AutofillMetricsCompanyTest_CompanyNameSuggestions_Test::TestBody() + 1190


GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8892005240)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[  FAILED  ] AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/0, where GetParam() = false (106 ms)
[ RUN      ] AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/1

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8890878640)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: CancelPendingQueries(0x7f8890878640)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[       OK ] AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/1 (8 ms)
[----------] 2 tests from AutofillMetricsTest/AutofillMetricsCompanyTest (136 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 2 test suites ran. (192 ms total)
[  PASSED  ] 2 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/0, where GetParam() = false

 1 FAILED TEST
[68391:15363:0122/182331.626948:1148450292239517:ERROR:kill_posix.cc(84)] Unable to terminate process group 68392: No such process (3)
[1/3] AutofillMetricsTest.AddressSuggestionsCount (48 ms)
[2/3] AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/0 (106 ms)
[3/3] AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/1 (8 ms)
1 test failed:
    AutofillMetricsTest/AutofillMetricsCompanyTest.CompanyNameSuggestions/0 (../../components/autofill/core/browser/autofill_metrics_unittest.cc:480)
Tests took 2 seconds

Sign in to add a comment