New issue
Advanced search Search tips

Issue 924155 link

Starred by 1 user
Status: Assigned
Owner:
g...@chromium.org
Cc:
llozano@chromium.org
michae...@chromium.org
achuith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromite rolls into chromium blocked due to linker errors

Project Member Reported by bpastene@chromium.org, Today (13 hours ago) 
See the roll attempts at https://chromium-review.googlesource.com/c/chromium/src/+/1421257

It's blocked on a couple simplechrome builders, which are failing during compile with linker errors:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8923959912407557792/+/steps/compile__with_patch_/0/stdout

Failing with:
[815/16559] LINK ./test_child_process
FAILED: test_child_process 
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: keep-text-section-prefix: unknown -z option

A version mismatch maybe? Given the 3 CLs in the blamelist of the roll, https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1415915/ is likely responsible. gbiv@, could you take a look?

Comment 1 by g...@chromium.org, Today (12 hours ago) 

Thanks!

We're passing a -z option that should only be passed to lld, so it makes sense that gold is upset about it. :)

Unfortunately, it looks like the -z option is coming directly from our prebuilt `environment` file. https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1405444 should've fixed this, but `cros chrome-sdk` is telling me that CHROMEOS_LKGM for a freshly synced Chrome is 11572.0.0, which happened before that CL landed.

IDK what the policy on submitting workarounds until CrOS' LKGM is updated is, so I'll upload a workaround CL soon.

Comment 2 by achuith@chromium.org, Today (11 hours ago)

Cc: michae...@chromium.org
We could also consider landing a newer LKGM CL manually, but that's probably a bad idea because too many PFQ bots are red.

Comment 3 by bpastene@chromium.org, Today (11 hours ago) 

I've since paused the chromite auto-roller, so if we just want to wait for a PFQ update of the lkgm, that SGTM. (I'm not seeing any recent changes in chromite that need rolling into chromium asap.)

Comment 4 by g...@chromium.org, Today (11 hours ago) 

Sounds like it isn't critical to get this in right away, so I'll defer to both of your judgement for the path forward here.

We already have a few hacks related to this gold/lld split (which should hopefully go away soon...) near that CL, so I'm personally equally OK with either waiting for LKGM or adding another thing that we'll revert in a few weeks.

In any case, workaround CL: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1427339
►

Sign in to add a comment