New issue
Advanced search Search tips

Issue 924137 link

Starred by 1 user
Status: Fixed
Owner:
tienmai@chromium.org
Closed: Today
Cc:
rogerta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

[GCPW] Multiple credential requests for an unsupported usage may disable GCPW.

Project Member Reported by tienmai@google.com, Today (14 hours ago) 
GCPW only supports 2 usages scenarios: machine unlock and machine logon. If we try to use GCPW for cred ui it will simply return without executing. If we request usage of GCPW for cred ui more than 4 times (say request a network share that requires a password and cancelling the password entry screen at every request), then on the 5th attempt to use GCPW as cred ui it will disable itself completely and will not run during unlock or logon anymore.
Project Member

Comment 1 by bugdroid1@chromium.org, Today (12 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50b28f6105a7447fb289b9d31d38f93278f34e34

commit 50b28f6105a7447fb289b9d31d38f93278f34e34
Author: Tien Mai <tienmai@chromium.org>
Date: Tue Jan 22 17:52:54 2019

Fix credential provider being disabled when we use it for cred ui too often.

The sentinel file was not being correctly deleted when GCPW usage was set to
a usage that was not supported and thus would be appended to on subsequent cred ui
requests. This would eventually cause GCPW to be completely disabled if no usage
that could delete the sentinel was requested.

Bug:  924137 
Change-Id: Iabbc8f438666cbddea1a9d2a1d04b54a0314579a
Reviewed-on: https://chromium-review.googlesource.com/c/1426738
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624825}
[modify] https://crrev.com/50b28f6105a7447fb289b9d31d38f93278f34e34/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/50b28f6105a7447fb289b9d31d38f93278f34e34/chrome/credential_provider/gaiacp/gaia_credential_provider.cc
[modify] https://crrev.com/50b28f6105a7447fb289b9d31d38f93278f34e34/chrome/credential_provider/gaiacp/gaia_credential_provider.h

Comment 2 by tienmai@google.com, Today (12 hours ago)

Status: Fixed (was: Started)
►

Sign in to add a comment