New issue
Advanced search Search tips

Issue 924116 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 924172



Sign in to add a comment

Roll googletest parts in Chomium as DEPS into V8

Project Member Reported by machenb...@chromium.org, Today (16 hours ago)

Issue description

This is to prevent breakages like  https://crbug.com/922379  and  https://crbug.com/922889 .

Currently third_party/googletest/src is a DEPS in V8 and in Chromium, while the content of third_party/googletest/ (basically a BUILD.gn file) is forked and checked-in in both Chromium and V8.

We should make a subtreed from src/third_party/googletest and roll this into V8. Ideally it'd contain its own DEPS file and we'd use recursive DEPS to get src/third_party/googletest/src.
 

Comment 1 by serg...@chromium.org, Today (16 hours ago)

Owner: serg...@chromium.org
Status: Started (was: Untriaged)
For this we'd need to create a gsubtreed mirror of the files in third_party/googletest in the chromium repo: https://crrev.com/c/1426686

Comment 2 by serg...@chromium.org, Today (12 hours ago)

Blockedon: 924172

Sign in to add a comment