New issue
Advanced search Search tips

Issue 924071 link

Starred by 1 user
Status: Assigned
Owner:
mrefaat@chromium.org
Cc:
justincohen@chromium.org
olivierrobin@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

MDC roll broken

Project Member Reported by stkhapugin@chromium.org, Today (19 hours ago) 
The MDC roll is broken because MDC changed their imports to be "framework style":

 https://github.com/material-components/material-components-ios/commit/056e4701f0ee64459f129977cfced71e4f864740

For example: #import "MaterialChips+ColorThemer.h" becomes #import <MaterialComponents/MaterialChips+ColorThemer.h>

Comment 1 by olivierrobin@chromium.org, Today (19 hours ago)

Cc: justincohen@chromium.org rohitrao@chromium.org
Note that MDC roll is probably blocking piper roll so we may need a temporary solution to unblock all rollers.

We can copy all headers in a "Framework" directory or compile MDC as a framework. In that case we can reuse the glob pattern expander we use for piper roll.

We can use it anyway for to make MDC roll easier.
►

Sign in to add a comment