New issue
Advanced search Search tips

Issue 924058 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2%-1.3% regression in system_health.memory_desktop at 624475:624475

Project Member Reported by mlippautz@chromium.org, Today (20 hours ago)

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Today (20 hours ago)

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=924058

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=6cafa18a696f390e124a7c79072b7d1dfe7c1ea39b7d23eac6ae7b047e72d208


Bot(s) for this bug's original alert(s):

linux-perf

system_health.memory_desktop - Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Today (20 hours ago)

Owner: w...@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to wez@chromium.org because this is the only CL in range:
Revert "Roll src-internal 9eb5076ed0c1..187f3372e0fd (1 commits)"

This reverts commit b1e66fcbbc8966733e6ecd02debcf9807625e1d7.

Reason for revert: Appeared to break win32-rel compilation (see https://crbug.com/923692).

Original change's description:
> Roll src-internal 9eb5076ed0c1..187f3372e0fd (1 commits)
> 
> https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb5076ed0c1..187f3372e0fd
> 
> 
> Created with:
>   gclient setdep -r src-internal@187f3372e0fd
> 
> The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> TBR=mmoss@chromium.org
> 
> Change-Id: I23aa116ccecf7b13eb6bf793a42475cd68555de0
> Reviewed-on: https://chromium-review.googlesource.com/c/1424000
> Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#624474}

TBR=mmoss@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Change-Id: Ib583d254068b247438f05f0e5bbde478416eea76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1423923
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624475}

Comment 3 by w...@chromium.org, Today (12 hours ago)

Cc: w...@chromium.org
 Issue 924057  has been merged into this issue.

Comment 4 by w...@chromium.org, Today (12 hours ago)

Owner: mlippautz@chromium.org
This was a revert of a src-internal roll which broke compilation on win32-rel; I don't see any way that it could be responsible for the performance regression referred to, unless the alert is bundling in some other changes that include something bad?

Sign in to add a comment