New issue
Advanced search Search tips

Issue 924028 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 738794



Sign in to add a comment

Move user_gesture_* files out of renderer/core/dom directory

Project Member Reported by hayato@chromium.org, Today (22 hours ago)

Issue description

This is a kind of a canned response.

It looks this CL [1] added some user_gesture related files to renderer/core/dom
directory, however, it is unclear to me how these files are related to dom. 

Please see
https://chromium.googlesource.com/chromium/src/+/master/third_party/blink/renderer/core/dom/README.md
for more info.

If you are not sure whether it is okay or not to put files in core/dom, please
make sure to add an owner (hayato or tkent) listed in core/dom/OWNERS in a review.
We are happy to help.

- [1] https://chromium-review.googlesource.com/c/chromium/src/+/515822/

 

Comment 1 by hayato@chromium.org, Today (22 hours ago)

Status: Assigned (was: Untriaged)
mustaq@, could you kindly work on this?

Comment 2 by hayato@chromium.org, Today (22 hours ago)

Blocking: 738794

Comment 3 by mustaq@chromium.org, Today (14 hours ago)

The CL above essentially replaced existing core/dom/DocumentUserGestureToken.h with platform/UserGestureIndicator.*, so it was not the original cause of the problem.

Re moving it out of core/dom/: note that this is part of a legacy code replaced by UAv2 in M72+.  We hope to remove it completely after a few milestones.

Are you okay if we defer this bug?

Comment 4 by hayato@google.com, Today (6 hours ago)

Owner: ----
Status: Available (was: Assigned)
Thanks for letting us know that. I appreciate your investigation.

> Are you okay if we defer this bug?

Yeah. It's totally fine.

Sign in to add a comment