Regression: Media controls disappear while user is still ‘muting’ and ‘unmuting’ the speaker using ‘Enter’ key |
||
Issue descriptionChrome Version : 73.0.3679.0 (Official Build) a6e4408c6b15bb6af7e93df4ad81373f7fadcb94-refs/branch-heads/3679@{#1} (32/64 Bit) OS : Mac(10.13.1, 10.13.6, 10.14.3) ,Win (7,8,8.1,10), Linux(14.04 LTS) Test URL: https://googlechrome.github.io/samples/picture-in-picture/ What steps will reproduce the problem? 1. Launch chrome and navigate to the above URL 2. Using ’Tab’ key shift focus on ’speaker’ icon and then press and hold ‘Enter’ key for few seconds to continuously ‘mute’ and ‘unmute’ the volume. 3. Observe Actual Result : Media controls disappear while user is still ‘muting’ and ‘unmuting’ the speaker using ‘Enter’ key Expected Result : Media controls should not disappear while user is ‘muting’ and ‘unmuting’ the speaker using ‘Enter’ key This is a regression issue broken in M-68 and below is the per-revision bisect info: Good Build : 68.0.3436.0 (Revision : 560158) Bad Build : 68.0.3437.0 (Revision : 560453) You are probably looking for a change made after 560374 (known good), but no later than 560375 (first known bad). Change-Log URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/ff828877e7dd93fb123bc4d6539d93a2187334dd..259b9dd2958a439531dca094106cb3f2d06e332e Suspect : https://chromium.googlesource.com/chromium/src/+/259b9dd2958a439531dca094106cb3f2d06e332e @Tommy Steimel: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also reproducible Beta Build #72.0.3626.64 and Stable build #71.0.3578.98 Kindly refer attached screen cast. Thank you..
,
Today
(10 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e6db3ab947b5926b1aa2aa93eb7234f4a55297c commit 1e6db3ab947b5926b1aa2aa93eb7234f4a55297c Author: Tommy Steimel <steimel@chromium.org> Date: Tue Jan 22 19:58:03 2019 [Media Controls] Stop controls from hiding during keyboard interaction This CL fixes an issue where the controls were relying on the panel element to receive keypress events to reset the hide timer. Instead, we want to reset the timer when the button panel receives keypress events, because the button panel will stop propagation of keypress events before the panel sees them. Bug: 924019 Change-Id: Ic85c023047c20cafe91da419a77c827ad619d632 Reviewed-on: https://chromium-review.googlesource.com/c/1426899 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#624880} [modify] https://crrev.com/1e6db3ab947b5926b1aa2aa93eb7234f4a55297c/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/1e6db3ab947b5926b1aa2aa93eb7234f4a55297c/third_party/blink/renderer/modules/media_controls/media_controls_impl.h [modify] https://crrev.com/1e6db3ab947b5926b1aa2aa93eb7234f4a55297c/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc [modify] https://crrev.com/1e6db3ab947b5926b1aa2aa93eb7234f4a55297c/third_party/blink/renderer/modules/media_controls/media_controls_media_event_listener.cc
,
Today
(9 hours ago)
|
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Today (13 hours ago)