New issue
Advanced search Search tips

Issue 924015 link

Starred by 1 user
Status: Untriaged
Owner:
zwisler@chromium.org
Cc:
groeck@chromium.org
diand...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

kernel: thermal: upstream thermal logging patches

Project Member Reported by drinkcat@google.com, Yesterday (24 hours ago) 
We carry 3 local patches in drivers/thermal/cpu_cooling.c to add logs about thermal events in chromeos kernel. We should probably try to upstream them.

commit a257153c52df5bafc9c5fefd3f7f14e8ee4781bc
Author: Brian Norris <briannorris@chromium.org>
Date:   Fri Nov 3 16:57:16 2017 -0700

    CHROMIUM: thermal: mark ratelimits as static

    Signed-off-by: Brian Norris <briannorris@chromium.org>
    Reviewed-by: Guenter Roeck <groeck@chromium.org>

commit f2858aaf489dc060a2e828397dfce994f46822a0
Author: Stephen Barber <smbarber@chromium.org>
Date:   Thu Sep 29 16:56:24 2016 -0700

    CHROMIUM: thermal: ratelimit thermal logging messages

    Signed-off-by: Stephen Barber <smbarber@chromium.org>
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Signed-off-by: Guenter Roeck <groeck@chromium.org>
    Signed-off-by: Justin TerAvest <teravest@chromium.org>

commit ec1c501a8093fed44a6697a5913ef2765f518e1f
Author: Ricky Liang <jcliang@chromium.org>
Date:   Fri Aug 26 10:55:43 2016 +0800

    CHROMIUM: thermal: add thermal logs in devfreq_cooling and cpu_cooling

    Signed-off-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/372558
    Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>    
    Signed-off-by: Stephen Barber <smbarber@chromium.org>

It looks like Ross started an attempt here: https://lkml.org/lkml/2018/10/23/20 , any follow-up?

Comment 1 by diand...@chromium.org, Today (12 hours ago) 

For Russ to answer, but my understanding was that we thought it was better to log thermal rate-limiting in userspace somehow.  Once we have that we could presumably revert/drop the CHROMIUM patches.

In general the idea is that when looking at feedback reports (especially those complaining about a system being slow) it's useful to see if we are being thermal throttled.

Comment 2 by zwisler@chromium.org, Today (11 hours ago) 

I got caught up in other things and this went to the back burner, but dianders@ provided a correct summary.  I don't think that the patches are generally applicable for upstream, so the goal was to find out another way to log this event outside of dmesg then revert the patches in the chromeos-4.19 tree.

If someone else has enough bandwidth to pick this up, I'd be fine with that.
►

Sign in to add a comment