New issue
Advanced search Search tips

Issue 923986 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add pkg_config template integrated into static_library and executable

Project Member Reported by yamaguchi@chromium.org, Yesterday (27 hours ago)

Issue description

Currently we have pkg_config template used under platform2/.
For example:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1401973/6/diagnostics/BUILD.gn#26

It'd be easier if the template is inlined into the block of static_library and executable commands.


Currently it's written like:

pkg_config("foo_pkg_deps_1") {
  pkg_deps = [ "bar1" ]
}
pkg_config("foo_pkg_deps_2") {
  pkg_deps = [ "bar2" ]
}
pkg_config("foo_pkg_deps_3") {
  pkg_deps = [ "bar3" ]
}
executable("foo") {
  configs += [ ":foo_pkg_deps_1" ]
  public_configs += [ ":foo_pkg_deps_2" ]
  all_dependent_configs += [ ":foo_pkg_deps_3" ]
  source = [ "foo.cc" ]
}


We'd like to write it like:

executable("foo") {
  pkg_deps = [ "bar1" ]
  public_pkg_deps = [ "bar2" ]
  all_dependent_pkg_deps = [ "bar3" ]
}

 

Sign in to add a comment