New issue
Advanced search Search tips

Issue 923929 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Yesterday
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

20436 byte regression in resource_sizes (MonochromePublic.apk) at 624169:624169

Project Member Reported by cjgrant@google.com, Yesterday (34 hours ago)

Issue description

Caused by “Return more than a single language with ULP language code locator”

Commit:	e6b6b4d6a3693171a005916d33aa3368cc1114b4

Alexandre, the binary size increase with this change is big enough to warrant checking into it.  Was it expected that there'd be a ~20 KB binary size hit for this change?

We now have a bot that checks for non-negligible binary size increases, but it doesn't seem to have fired in this case.

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Yesterday (34 hours ago)

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=923929

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=6d4cf00e77d6fe2272ce7e8c168048c280fb81989fdc619d24c3016b8acd9436


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Yesterday (34 hours ago)

Assigning to frechette@chromium.org because this is the only CL in range:
Return more than a single language with ULP language code locator.

- Modifies UlpLanguageCodeLocator and its helper functions to support more than a single quadtree.
- Adds second and third most spoken languages data, and modifies BUILD process to embed them into the helper functions.
- Augments the test for this extended functionality.

Bug: 850947
Change-Id: Ie2c44bbb562d8905454fb2dcf594d7eb4df9a3b4
Reviewed-on: https://chromium-review.googlesource.com/c/1409606
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624169}

Comment 3 by cjgrant@chromium.org, Yesterday (34 hours ago)

Note that the trybot appears to have computed a size ~50 bytes below the threshold.  Hence no alert.  

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/138755

Question still holds though.  Is this an expected change?  Is it avoidable in any way?

Comment 4 by frechette@chromium.org, Yesterday (34 hours ago)

Cc: yyushkina@chromium.org anthonyvd@chromium.org
This size difference is to be expected as we are adding raw data to help us infer better languages for users in India. Effort was put in to compress this data as much as possible (data consists of raw bits that is de-serialized into specialized data structure).

Comment 5 by cjgrant@chromium.org, Yesterday (34 hours ago)

Status: WontFix (was: Assigned)
Sounds good.  Thanks for the quick response!

Comment 6 by agrieve@chromium.org, Yesterday (32 hours ago)

Wonder if the raw bits are also compressed? Worth at least checking out (e.g. run it through gzip or out/Release/clang_x64/brotli to see if they would shrink a bunch more if compressed. if 50% or more, than probably worth it.

Comment 7 by frechette@chromium.org, Yesterday (32 hours ago)

I do not get any compression with gzip.

Sign in to add a comment