v8 bindings do not build deterministically |
||
Issue descriptionIt seems that something is not depending correctly in the gn files, as the file gen/third_party/blink/renderer/bindings/core/v8/double_or_performance_mark_options.cc does not exist yet when we attempt to compile it. /b/swarming/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/double_or_performance_mark_options.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"351477-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=349080 -DCR_LIBCXXABI_REVISION=347903 -D_LIBCPP_ENABLE_NODISCARD -D_LIBCPP_ABI_UNSTABLE -DCR_SYSROOT_HASH=e7c53f04bd88d29d075bfd1f62b073aeb69cbe09 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1 -DENABLE_IPC_FUZZER -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DWEBP_EXTERN=extern -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DVK_NO_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DVK_NO_PROTOTYPES -DV8_DEPRECATION_WARNINGS -DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DSUPPORT_WEBGL2_COMPUTE_CONTEXT=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DV8_DEPRECATION_WARNINGS -DLIBXSLT_STATIC -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/vulkan/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/abseil-cpp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/docs -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/vulkan/include -I../../third_party/skia/third_party/vulkanmemoryallocator -I../../third_party/skia/include/codec -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/vulkan/include -I../../third_party/angle/include -I../../third_party/angle/src/common/third_party/base -Igen/angle -I../../v8/include -Igen/v8/include -I../../third_party/libwebm/source -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/libxslt/src -I../../third_party/snappy/src -I../../third_party/snappy/linux -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Xclang -add-plugin -Xclang blink-gc-plugin -Wglobal-constructors -g0 -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wconversion -Wno-float-conversion -Wno-sign-conversion -Wno-implicit-float-conversion -Wno-implicit-int-conversion -Wno-shorten-64-to-32 -Wno-header-guard -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nspr -DLIBXML_STATIC= -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c gen/third_party/blink/renderer/bindings/core/v8/double_or_performance_mark_options.cc -o obj/third_party/blink/renderer/bindings/core/v8/bindings_core_impl/double_or_performance_mark_options.o clang++: error: no such file or directory: 'gen/third_party/blink/renderer/bindings/core/v8/double_or_performance_mark_options.cc' clang++: error: no input files
,
Yesterday
(34 hours ago)
The fix is to remove double_or_performance_mark_options from the build file. It's interesting that local build and trybot didn't complain this issue.
,
Yesterday
(34 hours ago)
ya thats weird :(
,
Yesterday
(34 hours ago)
Reverted already. Closing the issue.
,
Yesterday
(29 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbc69a32e41bcd9937b5a081925ddd615c5cd27c commit cbc69a32e41bcd9937b5a081925ddd615c5cd27c Author: Liquan(Max) Gu <maxlg@chromium.org> Date: Tue Jan 22 01:16:09 2019 Reland "[UserTimingL3] Mark API: DoubleOrOptions to Options" This is a reland of 64c192c467773e40249baf225ad3d2756694b174. The original CL didn't remove a union type that the IDL no longer generated, which was the cause of the compile failure. The trybot and the local build didn't capture this error. Original change's description: > [UserTimingL3] Mark API: DoubleOrOptions to Options > > According to the latest spec, the performance.mark API should only take an optional PerformanceMarkOptions as the second argument: https://w3c.github.io/user-timing. With the new change, we no longer allow the L3 users to pass in timestamp directly, but only allow them to set the attribute in the options. > > To align with this change, we need to change the implementation of the API, and the related tests. > > This CL is to reflect the above change. > > Bug: 758385 > Change-Id: I12a320f3c5f4faa57fe836fa52a463499aaf6d38 > Reviewed-on: https://chromium-review.googlesource.com/c/1418070 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Auto-Submit: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624641} Bug: 758385, 923926 Change-Id: I4b4d31989f9187cd7cca4c2fa150472aefd7cc5d Reviewed-on: https://chromium-review.googlesource.com/c/1426081 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624708} [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/renderer/bindings/core/v8/BUILD.gn [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/renderer/core/timing/performance.cc [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/renderer/core/timing/performance.h [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/renderer/core/timing/performance.idl [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/renderer/core/timing/performance_user_timing.cc [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/renderer/core/timing/performance_user_timing.h [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/web_tests/http/tests/performance-timing/custom-user-timing/po-customusertiming-mark.html [modify] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/web_tests/http/tests/performance-timing/custom-user-timing/po-customusertiming-measure.html [add] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/web_tests/http/tests/performance-timing/custom-user-timing/usertimingl3-mark-type-expected.txt [add] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/web_tests/http/tests/performance-timing/custom-user-timing/usertimingl3-mark-type.html [delete] https://crrev.com/cd6620389e6584de465e61977f69caa87467b7bc/third_party/blink/web_tests/virtual/custom-user-timing/http/tests/performance-timing/custom-user-timing/po-customusertiming-mark-expected.txt [delete] https://crrev.com/cd6620389e6584de465e61977f69caa87467b7bc/third_party/blink/web_tests/virtual/custom-user-timing/http/tests/performance-timing/custom-user-timing/po-customusertiming-measure-expected.txt [add] https://crrev.com/cbc69a32e41bcd9937b5a081925ddd615c5cd27c/third_party/blink/web_tests/virtual/custom-user-timing/http/tests/performance-timing/custom-user-timing/usertimingl3-mark-type-expected.txt
,
Yesterday
(28 hours ago)
I think the binding generator should warn us this kind of inconsistency. I'll file a bug for that. |
||
►
Sign in to add a comment |
||
Comment 1 by danakj@chromium.org
, Yesterday (34 hours ago)Owner: maxlg@chromium.org
Status: Assigned (was: Untriaged)