New issue
Advanced search Search tips

Issue 923923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Today
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

TestBrowserThreadBundleTest.MessageLoopTypeMismatch is flaky

Project Member Reported by gab@chromium.org, Yesterday (35 hours ago)

Issue description

[ RUN      ] TestBrowserThreadBundleTest.MessageLoopTypeMismatch

[WARNING] ../../third_party/googletest/src/googletest/src/gtest-death-test.cc:1110:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 5 threads. See https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.


Need to add
testing::GTEST_FLAG(death_test_style) = "threadsafe";
to this multi-threaded gtest death test.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Yesterday (33 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9b3d2f4c1d07c3e45df0937010417d6d246f566

commit a9b3d2f4c1d07c3e45df0937010417d6d246f566
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jan 21 20:55:06 2019

Unflake TestBrowserThreadBundleTest death tests

R=avi@chromium.org

Bug:  923923 
Change-Id: Ie6c2aa8b1084144e4477194315b86916ed0a95bf
Reviewed-on: https://chromium-review.googlesource.com/c/1426018
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624652}
[modify] https://crrev.com/a9b3d2f4c1d07c3e45df0937010417d6d246f566/content/public/test/test_browser_thread_bundle_unittest.cc

Comment 2 by kinuko@chromium.org, Yesterday (27 hours ago)

Labels: -Sheriff-Chromium

Comment 3 by gab@chromium.org, Today (14 hours ago)

Status: Fixed (was: Started)

Sign in to add a comment