New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 923916 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

problem building M72 branch: no type named 'ParamType'

Project Member Reported by pdr@chromium.org, Yesterday (35 hours ago)

Issue description

As reported on chromium-dev (https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/s0j4fYpHJQo):
This compile error appears when building the blink_platform_unittests target:
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-param-util.h:444:30: error: no type named 'ParamType' in 'blink::RasterInvalidatorTest_EffectWithAliasTransformWhoseParentChanges_Test'  typedef typename TestCase::ParamType ParamType;          ~~~~~~~~~~~~~~~~~~~^~~~~~~~~../../third_party/googletest/src/googletest/include/gtest/internal/gtest-param-util.h:698:24: error: no matching member function for call to 'push_back'      test_case_infos_.push_back(typed_test_info);      ~~~~~~~~~~~~~~~~~^~~~~~~~~../../third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc:691:1: note: in instantiation of function template specialization 'testing::internal::ParameterizedTestCaseRegistry::GetTestCasePatternHolder<blink::RasterInvalidatorTest>' requested hereTEST_P(RasterInvalidatorTest, AliasEffectParentChanges) {

This compile error was caused by this merge:
https://chromium-review.googlesource.com/c/chromium/src/+/1393455

I think this slipped by because the release builders don't build test targets. I'm not sure what to do here. Should we merge a patch that removes the test change? Or do nothing to avoid destabilizing the branch?
 

Comment 1 by schenney@chromium.org, Yesterday (35 hours ago)

Status: Assigned (was: Untriaged)

Comment 2 by vmp...@chromium.org, Yesterday (33 hours ago)

Cc: abdulsyed@chromium.org srinivassista@chromium.org
I don't think we usually fix test issues on release branches. +TPMs for opinions:

Should we merge a test-only change to the release branch so it can build, or should we just let it go?




Sign in to add a comment