As reported on chromium-dev (https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/s0j4fYpHJQo):
This compile error appears when building the blink_platform_unittests target:
../../third_party/googletest/src/googletest/include/gtest/internal/gtest-param-util.h:444:30: error: no type named 'ParamType' in 'blink::RasterInvalidatorTest_EffectWithAliasTransformWhoseParentChanges_Test' typedef typename TestCase::ParamType ParamType; ~~~~~~~~~~~~~~~~~~~^~~~~~~~~../../third_party/googletest/src/googletest/include/gtest/internal/gtest-param-util.h:698:24: error: no matching member function for call to 'push_back' test_case_infos_.push_back(typed_test_info); ~~~~~~~~~~~~~~~~~^~~~~~~~~../../third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc:691:1: note: in instantiation of function template specialization 'testing::internal::ParameterizedTestCaseRegistry::GetTestCasePatternHolder<blink::RasterInvalidatorTest>' requested hereTEST_P(RasterInvalidatorTest, AliasEffectParentChanges) {
This compile error was caused by this merge:
https://chromium-review.googlesource.com/c/chromium/src/+/1393455
I think this slipped by because the release builders don't build test targets. I'm not sure what to do here. Should we merge a patch that removes the test change? Or do nothing to avoid destabilizing the branch?
Comment 1 by schenney@chromium.org
, Yesterday (35 hours ago)