UkmBrowserTest.LogsTabId is failing *browser_tests on multiple builders |
|||||||||||
Issue descriptionExample builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29?limit=200 Regression range: https://chromium.googlesource.com/chromium/src/+log/6c7458dd455ec9e301dc7eb4a15953c81cc7eb40..434da2dcead98b9e81d6037ce8382b1f76aa9889?pretty=fuller&n=10000 Example log: [ RUN ] UkmBrowserTest.LogsTabId/1 [790:790:0121/070808.923984:WARNING:chrome_browser_main_chromeos.cc(547)] Running as stub user with profile dir: test-user [790:790:0121/070809.761743:INFO:remote_commands_service.cc(38)] Fetching remote commands. [790:790:0121/070809.761882:WARNING:remote_commands_service.cc(40)] Client is not registered. [790:790:0121/070809.762065:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator. [790:790:0121/070809.762173:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator. [790:790:0121/070809.762770:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [790:790:0121/070809.762887:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [790:790:0121/070809.952311:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [790:790:0121/070810.533222:WARNING:personal_data_manager.cc(487)] 0x6160000dda80 refresh is done, notifying PersonalDataChanged [790:790:0121/070810.592935:WARNING:personal_data_manager.cc(487)] 0x616000119780 refresh is done, notifying PersonalDataChanged [790:790:0121/070810.790483:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [790:790:0121/070811.663656:WARNING:loopback_server.cc(719)] Loopback sync persistent state file does not exist. [790:790:0121/070811.679928:ERROR:http_bridge.cc(126)] Not implemented reached in virtual void syncer::HttpBridgeFactory::OnSignalReceived() [790:997:0121/070811.928539:WARNING:sync_encryption_handler_impl.cc(1080)] Nigori had empty encryption keybag. [790:997:0121/070811.932293:WARNING:sync_encryption_handler_impl.cc(1080)] Nigori had empty encryption keybag. [790:790:0121/070811.952989:ERROR:account_tracker.cc(263)] OnOAuthError [790:790:0121/070811.953078:WARNING:account_tracker.cc(189)] Failed to get UserInfo for stub-user@example.com [790:790:0121/070812.041242:ERROR:chrome_device_id_helper.cc(42)] Device ID is not set for user. [790:790:0121/070812.042581:INFO:profile_sync_service.cc(1967)] ConfigureDataTypeManager not invoked because datatypes cannot be configured now [790:790:0121/070812.050452:INFO:profile_sync_service.cc(1967)] ConfigureDataTypeManager not invoked because datatypes cannot be configured now [790:899:0121/070812.265469:ERROR:mcs_client.cc(709)] Failed to log in to GCM, resetting connection. [790:790:0121/070812.332612:WARNING:personal_data_manager.cc(495)] 0x6160000dda80 has synced new data, refreshing [790:790:0121/070812.734277:WARNING:personal_data_manager.cc(487)] 0x6160000dda80 refresh is done, notifying PersonalDataChanged [790:1085:0121/070813.743461:WARNING:embedded_test_server.cc(237)] Request not handled. Returning 404: /favicon.ico [790:790:0121/070815.982048:FATAL:logo_service_impl.cc(596)] Check failed: !encoded_logo. #0 0x557786fdf531 in __interceptor_backtrace /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4051:13 #1 0x5577989ff7ef in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:820:39 #2 0x557798794720 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:591:29 #3 0x5577a5c0a9e8 in search_provider_logos::LogoServiceImpl::OnFreshLogoAvailable(std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, bool, bool, bool, SkBitmap const&) ./../../components/search_provider_logos/logo_service_impl.cc:596:7 #4 0x5577a5c0a48c in search_provider_logos::LogoServiceImpl::OnFreshLogoParsed(bool*, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >) ./../../components/search_provider_logos/logo_service_impl.cc:500:5 #5 0x5577a5c129b0 in void base::internal::FunctorTraits<void (search_provider_logos::LogoServiceImpl::*)(bool*, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >), void>::Invoke<void (search_provider_logos::LogoServiceImpl::*)(bool*, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >), base::WeakPtr<search_provider_logos::LogoServiceImpl>, bool*, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > >(void (search_provider_logos::LogoServiceImpl::*)(bool*, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >), base::WeakPtr<search_provider_logos::LogoServiceImpl>&&, bool*&&, bool&&, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >&&) ./../../base/bind_internal.h:516:12 #6 0x5577a5c12697 in MakeItSo<void (search_provider_logos::LogoServiceImpl::*)(bool *, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >), base::WeakPtr<search_provider_logos::LogoServiceImpl>, bool *, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > ./../../base/bind_internal.h:636:5 #7 0x5577a5c12697 in RunImpl<void (search_provider_logos::LogoServiceImpl::*)(bool *, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >), std::__1::tuple<base::WeakPtr<search_provider_logos::LogoServiceImpl>, base::internal::OwnedWrapper<bool>, bool>, 0, 1, 2> ./../../base/bind_internal.h:689:0 #8 0x5577a5c12697 in base::internal::Invoker<base::internal::BindState<void (search_provider_logos::LogoServiceImpl::*)(bool*, bool, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >), base::WeakPtr<search_provider_logos::LogoServiceImpl>, base::internal::OwnedWrapper<bool>, bool>, void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>::RunOnce(base::internal::BindStateBase*, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >&&) ./../../base/bind_internal.h:658:0 #9 0x5577a5c0fab9 in Run ./../../base/callback.h:99:12 #10 0x5577a5c0fab9 in void base::internal::ReplyAdapter<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > >(base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > >*) ./../../base/post_task_and_reply_with_result_internal.h:30:0 #11 0x5577a5c0fe85 in Invoke<void (*)(base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > > *), base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > > *> ./../../base/bind_internal.h:416:12 #12 0x5577a5c0fe85 in MakeItSo<void (*)(base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > > *), base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > > *> ./../../base/bind_internal.h:616:0 #13 0x5577a5c0fe85 in RunImpl<void (*)(base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > > *), std::__1::tuple<base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, base::internal::OwnedWrapper<std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > > > >, 0, 1> ./../../base/bind_internal.h:689:0 #14 0x5577a5c0fe85 in base::internal::Invoker<base::internal::BindState<void (*)(base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > >*), base::OnceCallback<void (std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >)>, base::internal::OwnedWrapper<std::__1::unique_ptr<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> >, std::__1::default_delete<std::__1::unique_ptr<search_provider_logos::EncodedLogo, std::__1::default_delete<search_provider_logos::EncodedLogo> > > > > >, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/bind_internal.h:658:0 #15 0x55779894ce88 in Run ./../../base/callback.h:99:12 #16 0x55779894ce88 in base::(anonymous namespace)::PostTaskAndReplyRelay::RunReply(base::(anonymous namespace)::PostTaskAndReplyRelay) ./../../base/threading/post_task_and_reply_impl.cc:97:0 #17 0x55779894d0b5 in Invoke<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay> ./../../base/bind_internal.h:416:12 #18 0x55779894d0b5 in MakeItSo<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay> ./../../base/bind_internal.h:616:0 #19 0x55779894d0b5 in RunImpl<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), std::__1::tuple<base::(anonymous namespace)::PostTaskAndReplyRelay>, 0> ./../../base/bind_internal.h:689:0 #20 0x55779894d0b5 in base::internal::Invoker<base::internal::BindState<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay>, void ()>::RunOnce(base::internal::BindStateBase*) ./../../base/bind_internal.h:658:0 #21 0x557798a68d87 in Run ./../../base/callback.h:99:12 #22 0x557798a68d87 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:99:0 #23 0x5577987bfc65 in base::MessageLoopImpl::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop_impl.cc:352:46 #24 0x5577987c1336 in DeferOrRunPendingTask ./../../base/message_loop/message_loop_impl.cc:363:5 #25 0x5577987c1336 in base::MessageLoopImpl::DoWork() ./../../base/message_loop/message_loop_impl.cc:451:0 #26 0x557798a53f41 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:210:31 #27 0x5577987beb19 in base::MessageLoopImpl::Run(bool) ./../../base/message_loop/message_loop_impl.cc:304:12 #28 0x557798859e87 in base::RunLoop::Run() ./../../base/run_loop.cc:150:14 #29 0x55779a34dcfe in content::WindowedNotificationObserver::Wait() ./../../content/public/test/test_utils.cc:371:15 #30 0x55779a2aaaf6 in WaitForLoadStopWithoutSuccessCheck ./../../content/public/test/browser_test_utils.cc:686:24 #31 0x55779a2aaaf6 in content::WaitForLoadStop(content::WebContents*) ./../../content/public/test/browser_test_utils.cc:692:0 #32 0x557798bf41ee in ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete(Browser*, GURL const&, int, WindowOpenDisposition, int) ./../../chrome/test/base/ui_test_utils.cc:201:5 #33 0x557787b93d1b in metrics::UkmBrowserTestBase::NavigateAndGetSource(Browser*, GURL const&) ./../../chrome/browser/metrics/ukm_browsertest.cc:194:5 #34 0x557787b933cd in metrics::UkmBrowserTest_LogsTabId_Test::RunTestOnMainThread() ./../../chrome/browser/metrics/ukm_browsertest.cc:844:40 #35 0x55779a2a535a in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:462:5 #36 0x557798d56025 in Run ./../../base/callback.h:129:12 #37 0x557798d56025 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1794:0 #38 0x557798d5334d in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1182:18 #39 0x55778bcd4a99 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:663:32 #40 0x557790a65814 in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:984:13 #41 0x557791e340dc in Run ./../../base/callback.h:129:12 #42 0x557791e340dc in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:0 #43 0x557790a623f9 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:918:25 #44 0x557790a6c978 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:144:15 #45 0x557790a5c592 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32 #46 0x5577976c421b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:545:10 #47 0x5577976c421b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:954:0 #48 0x5577976c3589 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:868:12 #49 0x5577a0527558 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:461:29 #50 0x5577976be2c8 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #51 0x55779a2a3d29 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:349:3 #52 0x557798be789d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:287:20 #53 0x55779bb04ce1 in SyncTest::SetUp() ./../../chrome/browser/sync/test/integration/sync_test.cc:270:25 #54 0x557787ba6df3 in metrics::UkmBrowserTestBase::SetUp() ./../../chrome/browser/metrics/ukm_browsertest.cc:167:15 #55 0x55778d1ef97c in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #56 0x55778d1ef97c in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2494:0 #57 0x55778d1f1f9a in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2675:11 #58 0x55778d1f34d7 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2803:28 #59 0x55778d21b9e7 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5241:44 #60 0x55778d21ab15 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #61 0x55778d21ab15 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4843:0 #62 0x557798c414ca in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2499:46 #63 0x557798c414ca in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0 #64 0x55779870cb52 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:71:21 #65 0x55779a33c366 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:647:31 #66 0x55779870d946 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:184:10 #67 0x55779870c73f in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #68 0x7f82b2c20f45 in __libc_start_main ??:0:0 #69 0x557786f9164a in _start ??:0:0 Cannot upload crash dump: failed to open [930:930:0121/070817.174209:WARNING:x11_util.cc(1424)] X error received: serial 482, error_code 9 (BadDrawable), request_code 62, minor_code 0 (Unknown)
,
Yesterday
(38 hours ago)
Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1420500, will attempt revert.
,
Yesterday
(37 hours ago)
It should already be reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1424944
,
Yesterday
(37 hours ago)
Relanding r624571 and will investigate.
,
Yesterday
(36 hours ago)
Suspect is r1405431: - Kyle could you please help debugging? - Marc I cc'd you in case you have any idea.
,
Yesterday
(36 hours ago)
,
Yesterday
(36 hours ago)
Sorry, wrong link. Suspect is crrev.com/c/1405431.
,
Yesterday
(36 hours ago)
Yes, from the failing stack, I'm fairly sure crrev.com/c/1405431 is the culprit. Seems to just be a bad DCHECK; it should probably be "DCHECK(!encoded_logo->encoded_image)" rather than "DCHECK(!encoded_logo)". It's weird that this breaks just UKM tests specifically.
,
Yesterday
(36 hours ago)
It should be replaced with DCHECK(!encoded_logo || !encoded_logo->encoded_image); since the line can be reached with DOWNLOAD_OUTCOME_MISSING_REQUIRED_IMAGE and DOWNLOAD_OUTCOME_DOWNLOAD_FAILED. That is for sure a bug.
,
Yesterday
(36 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faaa279bbc2e1656811684ffac781e8418a665a0 commit faaa279bbc2e1656811684ffac781e8418a665a0 Author: Tsuyoshi Horo <horo@chromium.org> Date: Mon Jan 21 17:57:28 2019 Reland "Refactor RedirectInfo::ComputeRedirectInfo()" This is a reland of d0e9b098e5f320f919460df29a6110cfade58031 Looks like this wasn't the culprit. Original change's description: > Refactor RedirectInfo::ComputeRedirectInfo() > > Currently HttpResponseHeaders argument is used only to get the Referrer-Policy > header. > > I'm going to use this method while loading signed exchange. While handling a > synthesized redirection, I don't want create a new HttpResponseHeaders just for > passing the Referrer-Policy header. > So this CL removes HttpResponseHeaders argument and introduces > referrer_policy_header argument. > > Bug: 920905 > Change-Id: Ie3f0e71b4c99845da246261824de4c23564eefc4 > Reviewed-on: https://chromium-review.googlesource.com/c/1420500 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624513} TBR=horo@chromium.org,caseq@chromium.org,mmenke@chromium.org Bug: 920905, 923894 Change-Id: I0ad4c1ade7dbd47e257ed0d5a882c7ccd796e75d Reviewed-on: https://chromium-review.googlesource.com/c/1425498 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#624606} [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/content/browser/devtools/devtools_url_loader_interceptor.cc [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/content/common/service_worker/service_worker_loader_helpers.cc [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/headless/test/test_network_interceptor.cc [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/net/url_request/redirect_info.cc [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/net/url_request/redirect_info.h [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/net/url_request/redirect_info_unittest.cc [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/net/url_request/redirect_util.cc [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/net/url_request/redirect_util.h [modify] https://crrev.com/faaa279bbc2e1656811684ffac781e8418a665a0/net/url_request/url_request_job.cc
,
Yesterday
(36 hours ago)
@ #10: I had stumbled on that CL too but it landed on Jan 17th and the regression on the bot is on Jan 21st (and even if we assume other failures we hiding this, it was green on Jan 18th).
,
Yesterday
(35 hours ago)
Latest good revision is 6c7458dd455ec9e301dc7eb4a15953c81cc7eb40 (r624510). Successful run : https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31146 where the test passed on shard #20 and #25 : https://chromium-swarm.appspot.com/task?id=42877e8cfa8a4a10&refresh=10&show_raw=1 https://chromium-swarm.appspot.com/task?id=42877e9735107a10&refresh=10&show_raw=1 so while r623783 seems related, I don't think it can be the unique cause.
,
Yesterday
(35 hours ago)
From https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg the regression range is even tighter : https://chromium.googlesource.com/chromium/src/+log/93d53b07aa2b6a4f5c4fdcc006067816e604a3e2..30b9a5c31e27cd3c178f598a4aec27570f6510ef?pretty=fuller&n=10000 So I'm going to revert r624514 + r624515 as a likely (though hard to believe..?!) culprit.
,
Yesterday
(35 hours ago)
,
Yesterday
(35 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4205d6e8d3370bc816d722e908a372921936dd8a commit 4205d6e8d3370bc816d722e908a372921936dd8a Author: Gabriel Charette <gab@chromium.org> Date: Mon Jan 21 18:46:27 2019 Revert "Updates the bottom border to be 15% black instead of black." This reverts commit f3a6c253c7ae2eb42dd58de281587dbf110ef493. Reason for revert: suspected for https://bugs.chromium.org/p/chromium/issues/detail?id=923894#c14 Original change's description: > Updates the bottom border to be 15% black instead of black. > > This is a UX issue that came up during https://crbug.com/918788 > > Bug: 853593 > Change-Id: If0efdba2d344ee379fb560c61dc43ea4a14c0510 > Reviewed-on: https://chromium-review.googlesource.com/c/1415232 > Commit-Queue: Jay Harris <harrisjay@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624515} TBR=bsep@chromium.org,harrisjay@chromium.org Change-Id: I7ff365b2fcfafdbd75f6bd506c56f07ab806579d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853593, 923894 Reviewed-on: https://chromium-review.googlesource.com/c/1425997 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624635} [modify] https://crrev.com/4205d6e8d3370bc816d722e908a372921936dd8a/chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc
,
Yesterday
(35 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de610823c81c9740c5e5174dc748389caeb37f35 commit de610823c81c9740c5e5174dc748389caeb37f35 Author: Gabriel Charette <gab@chromium.org> Date: Mon Jan 21 18:50:42 2019 Revert "Adds a separator between custom tab bar and title, based on UX feedback." This reverts commit f207ec9653d036442e5738a4740b04506d7fe346. Reason for revert: suspected for https://bugs.chromium.org/p/chromium/issues/detail?id=923894#c14 Original change's description: > Adds a separator between custom tab bar and title, based on UX feedback. > > Previously, a similar separator was drawn. However, this separator > was always shown (when the theme color was white-ish), and the desired > behavior is to *only* render the separator when the custom tab bar > is visible AND the custom tab bar is white-ish. > > This CL will cause a 15% black separator to be drawn at the top of the > custom tab bar, blended with the apps theme color, so it looks like > the separator is drawn onto the title bar. > > Bug: 918788 > Change-Id: Iba020fe4f059558fe355d18236d5226d35f3a2aa > Reviewed-on: https://chromium-review.googlesource.com/c/1414535 > Commit-Queue: Jay Harris <harrisjay@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624514} TBR=bsep@chromium.org,harrisjay@chromium.org Change-Id: I16e4607f127301e3c579277f92b2549b51a92266 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918788, 923894 Reviewed-on: https://chromium-review.googlesource.com/c/1425999 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624638} [modify] https://crrev.com/de610823c81c9740c5e5174dc748389caeb37f35/chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc [modify] https://crrev.com/de610823c81c9740c5e5174dc748389caeb37f35/chrome/browser/ui/views/location_bar/custom_tab_bar_view.h
,
Yesterday
(33 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02f2825ab10a2d6bae105d2a6c94c28f055193e9 commit 02f2825ab10a2d6bae105d2a6c94c28f055193e9 Author: Gabriel Charette <gab@chromium.org> Date: Mon Jan 21 21:06:50 2019 Reland "Adds a separator between custom tab bar and title, based on UX feedback." This reverts commit de610823c81c9740c5e5174dc748389caeb37f35. Reason for reland : didn't fix it. Original change's description: > Revert "Adds a separator between custom tab bar and title, based on UX feedback." > > This reverts commit f207ec9653d036442e5738a4740b04506d7fe346. > > Reason for revert: suspected for https://bugs.chromium.org/p/chromium/issues/detail?id=923894#c14 > > Original change's description: > > Adds a separator between custom tab bar and title, based on UX feedback. > > > > Previously, a similar separator was drawn. However, this separator > > was always shown (when the theme color was white-ish), and the desired > > behavior is to *only* render the separator when the custom tab bar > > is visible AND the custom tab bar is white-ish. > > > > This CL will cause a 15% black separator to be drawn at the top of the > > custom tab bar, blended with the apps theme color, so it looks like > > the separator is drawn onto the title bar. > > > > Bug: 918788 > > Change-Id: Iba020fe4f059558fe355d18236d5226d35f3a2aa > > Reviewed-on: https://chromium-review.googlesource.com/c/1414535 > > Commit-Queue: Jay Harris <harrisjay@chromium.org> > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624514} > > TBR=bsep@chromium.org,harrisjay@chromium.org > > Change-Id: I16e4607f127301e3c579277f92b2549b51a92266 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 918788, 923894 > Reviewed-on: https://chromium-review.googlesource.com/c/1425999 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624638} TBR=gab@chromium.org,bsep@chromium.org,harrisjay@chromium.org Change-Id: I107e52387e2fd3a5072c484e39c883cfabe7349c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918788, 923894 Reviewed-on: https://chromium-review.googlesource.com/c/1425968 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624671} [modify] https://crrev.com/02f2825ab10a2d6bae105d2a6c94c28f055193e9/chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc [modify] https://crrev.com/02f2825ab10a2d6bae105d2a6c94c28f055193e9/chrome/browser/ui/views/location_bar/custom_tab_bar_view.h
,
Yesterday
(32 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c44ee8b46204c637a34012809857363ea88aac2f commit c44ee8b46204c637a34012809857363ea88aac2f Author: Gabriel Charette <gab@chromium.org> Date: Mon Jan 21 21:25:59 2019 Reland "Updates the bottom border to be 15% black instead of black." This reverts commit 4205d6e8d3370bc816d722e908a372921936dd8a. Reason for reland : didn't fix it. Original change's description: > Revert "Updates the bottom border to be 15% black instead of black." > > This reverts commit f3a6c253c7ae2eb42dd58de281587dbf110ef493. > > Reason for revert: suspected for https://bugs.chromium.org/p/chromium/issues/detail?id=923894#c14 > > Original change's description: > > Updates the bottom border to be 15% black instead of black. > > > > This is a UX issue that came up during https://crbug.com/918788 > > > > Bug: 853593 > > Change-Id: If0efdba2d344ee379fb560c61dc43ea4a14c0510 > > Reviewed-on: https://chromium-review.googlesource.com/c/1415232 > > Commit-Queue: Jay Harris <harrisjay@chromium.org> > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624515} > > TBR=bsep@chromium.org,harrisjay@chromium.org > > Change-Id: I7ff365b2fcfafdbd75f6bd506c56f07ab806579d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 853593, 923894 > Reviewed-on: https://chromium-review.googlesource.com/c/1425997 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624635} TBR=gab@chromium.org,bsep@chromium.org,harrisjay@chromium.org Change-Id: I6011811309c67dde14d7e390f8aabba54c5db111 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853593, 923894 Reviewed-on: https://chromium-review.googlesource.com/c/1426013 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624677} [modify] https://crrev.com/c44ee8b46204c637a34012809857363ea88aac2f/chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc
,
Yesterday
(27 hours ago)
,
Yesterday
(25 hours ago)
All suspected CLs in the blame range seem to have been once reverted and relanded?
,
Today
(23 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bcd3ed173a9aeea913a31b49036d6f148c72476 commit 1bcd3ed173a9aeea913a31b49036d6f148c72476 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Tue Jan 22 06:22:37 2019 Disable UkmBrowserTest.LogsTabId on ChromeOS No clue has found yet, while most suspected CLs have been once reverted but relanded. Suppressing to reduce noise on builders. TBR=gab@chromium.org Bug: 923894 Change-Id: Ida043df3d46a73507ca1b31686d7497bc53d00ed Reviewed-on: https://chromium-review.googlesource.com/c/1426206 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#624735} [modify] https://crrev.com/1bcd3ed173a9aeea913a31b49036d6f148c72476/chrome/browser/metrics/ukm_browsertest.cc
,
Today
(14 hours ago)
@ #21: Indeed all CLs in suspected range have reverted in relanded so something other than a source change is causing this seems like? @asvitkine for metrics triage
,
Today
(14 hours ago)
+rkaplow to take a look
,
Today
(13 hours ago)
I'm still pretty sure that crrev.com/c/1405431 is the culprit. Assigning to author to investigate.
,
Today
(13 hours ago)
Reverting https://crrev.com/c/1405431 in https://crrev.com/c/1426879
,
Today
(12 hours ago)
Re-enabled the test in https://crrev.com/c/1426999
,
Today
(12 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/646c49ba49591526ab3faeae18d7fbc3f70c2eca commit 646c49ba49591526ab3faeae18d7fbc3f70c2eca Author: Kyle Milka <kmilka@chromium.org> Date: Tue Jan 22 17:37:29 2019 Revert "Disable UkmBrowserTest.LogsTabId on ChromeOS" This reverts commit 1bcd3ed173a9aeea913a31b49036d6f148c72476. Reason for revert: reverted crrev.com/c/1426879, re-enabling this test Original change's description: > Disable UkmBrowserTest.LogsTabId on ChromeOS > > No clue has found yet, while most suspected CLs have been once > reverted but relanded. Suppressing to reduce noise on builders. > > TBR=gab@chromium.org > > Bug: 923894 > Change-Id: Ida043df3d46a73507ca1b31686d7497bc53d00ed > Reviewed-on: https://chromium-review.googlesource.com/c/1426206 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624735} TBR=kinuko@chromium.org,gab@chromium.org Change-Id: I10db608f00c9701fc14b4b97104c1b4ac802f607 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923894 Reviewed-on: https://chromium-review.googlesource.com/c/1426999 Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#624818} [modify] https://crrev.com/646c49ba49591526ab3faeae18d7fbc3f70c2eca/chrome/browser/metrics/ukm_browsertest.cc
,
Today
(9 hours ago)
,
Today
(7 hours ago)
Looks to be fine after the revert. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by gab@chromium.org
, Yesterday (38 hours ago)