New issue
Advanced search Search tips

Issue 923887 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DumpAccessibilityTreeTest.AccessibilityAudio is flaking content_browsertests on Linux Tests (dbg)

Project Member Reported by gab@google.com, Yesterday (38 hours ago)

Issue description

Flaky bot : https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29?limit=200

First failure @ 8a3b374352516c834b2fb7e7389d2caef2200083 (but since it's flaky the faulty CL could have been a few builds before).

Likely range: https://chromium.googlesource.com/chromium/src/+log/7a09c7c9b43bcdb9d0cb1c84439e3061cab1bbbc..8a3b374352516c834b2fb7e7389d2caef2200083?pretty=fuller&n=10000

Typical failure log:

[ RUN      ] DumpAccessibilityTreeTest.AccessibilityAudio
Xlib:  extension "RANDR" missing on display ":100".

DevTools listening on ws://127.0.0.1:41907/devtools/browser/8b434518-9d42-4c41-b070-d14ff7e92c6b
[21250:21250:0118/051850.603808:INFO:dump_accessibility_browsertest_base.cc(229)] File not found: /b/s/w/ir/content/test/data/accessibility/html/audio-expected-blink.txt
[21250:21250:0118/051850.603925:INFO:dump_accessibility_browsertest_base.cc(230)] No expectation file present, ignoring test on this platform. To run this test anyway, create /b/s/w/ir/content/test/data/accessibility/html/audio-expected-blink.txt (it can be empty) and then run content_browsertests with the switch: --generate-accessibility-test-expectations
[21250:21250:0118/051850.713695:INFO:dump_accessibility_browsertest_base.cc(244)] Testing: /b/s/w/ir/content/test/data/accessibility/html/audio.html
[21250:21250:0118/051850.713836:INFO:dump_accessibility_browsertest_base.cc(246)] Expected output: /b/s/w/ir/content/test/data/accessibility/html/audio-expected-auralinux.txt
../../content/browser/accessibility/dump_accessibility_browsertest_base.cc:378: Failure
Value of: is_different
  Actual: true
Expected: false
Stack trace:
#0 0x0000578ae989 StackTraceGetter::CurrentStackTrace()
#1 0x0000578c2264 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#2 0x0000578c1c5e testing::internal::AssertHelper::operator=()
#3 0x0000568dd553 content::DumpAccessibilityTestBase::RunTestForPlatform()
#4 0x0000568db7c7 content::DumpAccessibilityTestBase::RunTest()
#5 0x0000568f28c4 content::DumpAccessibilityTreeTest::RunHtmlTest()
#6 0x0000568eec91 content::DumpAccessibilityTreeTest_AccessibilityAudio_Test::RunTestOnMainThread()
#7 0x000058908ac4 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
(...)

[21250:21250:0118/051851.505551:ERROR:dump_accessibility_browsertest_base.cc(403)] Diff:
* Line Expected
- ---- --------
     1 [document web]
     2 ++[section]
     3 ++++[audio]
     4 ++++++[section]
     5 ++++++++[tool bar] name='audio' description='audio' horizontal
     6 ++++++++++[tool bar] name='audio' description='audio' horizontal
     7 ++++++++++++[push button] name='play' xml-roles:button
     8 ++++++++++++[text] name='0:00'
     9 ++++++++++++[text] name='/ 0:00'
    10 ++++++++++++[slider] description='audio time scrubber' horizontal xml-roles:slider
    11 ++++++++++++[section]
    12 ++++++++++++++[section]
*   13 ++++++++++++++[push button] name='mute' xml-roles:button
*   14 <-- End-of-file -->

Actual
------
[document web]
++[section]
++++[audio]
++++++[section]
++++++++[tool bar] name='audio' description='audio' horizontal
++++++++++[tool bar] name='audio' description='audio' horizontal
++++++++++++[push button] name='play' xml-roles:button
++++++++++++[text] name='0:00'
++++++++++++[text] name='/ 0:00'
++++++++++++[slider] description='audio time scrubber' horizontal xml-roles:slider
++++++++++++[section]
++++++++++++++[section]
++++++++++++++[slider] name='volume' horizontal xml-roles:slider
++++++++++++++[push button] name='mute' xml-roles:button
++++++++++++[push button] name='show more media controls' description='more options' xml-roles:button
<-- End-of-file -->
[21250:21302:0118/051851.675115:ERROR:browser_process_sub_thread.cc(209)] Waited 26 ms for network service
[21250:21318:0118/051851.676959:ERROR:process_posix.cc(329)] Unable to terminate process 21323: No such process (3)
[21250:21318:0118/051851.677521:WARNING:internal_linux.cc(64)] Failed to read /proc/21323/stat
[21250:21302:0118/051851.678120:WARNING:discardable_shared_memory_manager.cc(410)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[21250:21554:0118/051851.680520:WARNING:internal_linux.cc(64)] Failed to read /proc/21319/stat
[  FAILED  ] DumpAccessibilityTreeTest.AccessibilityAudio, where TypeParam =  and GetParam() =  (3746 ms)
 

Comment 1 by gab@google.com, Yesterday (38 hours ago)

Cc: nhiroki@chromium.org tangltom@chromium.org

Comment 2 by gab@google.com, Yesterday (38 hours ago)

** ++++++++++++++[slider] name='volume' horizontal xml-roles:slider
++++++++++++++[push button] name='mute' xml-roles:button
** ++++++++++++[push button] name='show more media controls' description='more options' xml-roles:button

the "slider" and "show more media controls" button appear to be at fault in the diff

Comment 3 by tangltom@chromium.org, Yesterday (38 hours ago)

The audio-expected-auralinux.txt file was updated 3 days ago with https://chromium-review.googlesource.com/c/chromium/src/+/1393843

Comment 4 by gab@chromium.org, Yesterday (37 hours ago)

Cc: hferre...@igalia.com
Owner: dmazz...@chromium.org
Status: Assigned (was: Started)
Hmmm, that's quite interesting but that landed as r624397 and the first flake is at r624091.

@hferreiro@igalia.com : any idea?
@dmazzoni : not sure how to triage this (no clear culprit in regression range; would rather not blindly disable test but it's a recurring flake on the bots and we can't keep it much longer). Please assess, thanks

Comment 5 by dmazz...@chromium.org, Yesterday (31 hours ago)

Owner: lethalantidote@chromium.org
I'm reverting CJ's change.

https://chromium-review.googlesource.com/c/chromium/src/+/1426162

There are a few possibilities I can think of:

* What's displayed depends on the window size, which isn't 100% consistent in tests, or
* Some of the content loads dynamically

Both cases can be fixed, see @WAIT-FOR if content is loading dynamically and sometimes the test is running before the DOM has finished loading

Project Member

Comment 6 by bugdroid1@chromium.org, Yesterday (30 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa

commit 35bd215f5821e246dbcfa69ea0cc00903fc9c6fa
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Jan 21 23:27:45 2019

Revert "Updates time values to use aria attributes."

This reverts commit 61348b6f02c3a00699cc39b0a85005fc876fcf7f.

Reason for revert: crbug.com/923887 causing flakiness in
DumpAccessibilityTreeTest.AccessibilityAudio

Original change's description:
> Updates time values to use aria attributes.
> 
> This CL changes the TimeRemaining and TimeElapsed values to use aria
> attributes directly instead of explicitly creating accessibility nodes.
> 
> Bug: 836549
> Change-Id: I7036d9e0a2b8f956f3c88bc9e838e2001830400b
> Reviewed-on: https://chromium-review.googlesource.com/c/1393843
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624397}

TBR=dmazzoni@chromium.org,alexmos@chromium.org,lethalantidote@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836549, 923887
Change-Id: Ia9e8cf1717de8e27e3708767f00c329d74bcc239
Reviewed-on: https://chromium-review.googlesource.com/c/1426162
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624691}
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/content/app/strings/content_strings.grd
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/content/test/data/accessibility/html/audio-expected-auralinux.txt
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_current_time_display_element.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
[delete] https://crrev.com/45ce00a7dc3fb08046922af7d626464fe0dc0932/third_party/blink/web_tests/media/controls/accessibility-time-element.html
[modify] https://crrev.com/35bd215f5821e246dbcfa69ea0cc00903fc9c6fa/third_party/blink/web_tests/media/media-controls.js

Comment 7 by gab@chromium.org, Today (14 hours ago)

Revert landed in r624691 yet there are still more flakes (though less) since.

Latest flake @ https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/55871 against r624756.

Comment 8 by kinuko@chromium.org, Today (4 hours ago)

Cc: lethalantidote@chromium.org
 Issue 923993  has been merged into this issue.

Sign in to add a comment