New issue
Advanced search Search tips

Issue 923879 link

Starred by 2 users
Status: Started
Owner:
fbeaufort@chromium.org
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 917303



Sign in to add a comment

<video autopictureinpicture> should be eligible to enter Auto Picture-in-Picture

Project Member Reported by fbeaufort@chromium.org, Yesterday (39 hours ago) 
Chrome Version       : 73.0.3679.0

<video autopictureinpicture> does not trigger the algorithm to select the Auto Picture-in-Picture element. The only way to trigger it is to set/unset the autoPictureInPicture attribute in JavaScript: https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc?l=141&rcl=3e74f7d6343cfde767e7329ea5ffadc22d3bae23

Note that this only applies in the context of a PWA window.

Comment 1 by mlamouri@chromium.org, Yesterday (38 hours ago) 

I think what might happen is that `SetBooleanAttribute()` isn't called if your HTML is:
```
<video autopictureinpicture></video>
```

The reason is that the video element is created *after* the attribute is set. You would need to look at whether the attribute is there when the element is created. This is different from the disableremoteplayback attribute or most HTML attributes as they rarely have an immediate action.

I think you would need to get a call when `ParserDidSetAttribute` which I realise is going to be a challenge in the context of a HTMLVideoElement extension. At the moment, the I think you would need to have this done at the HTMLVideoElement level.

Comment 2 by fbeaufort@chromium.org, Today (20 hours ago)

Labels: -OS-Android OS-Mac
Status: Started (was: Assigned)
WIP CL at https://chromium-review.googlesource.com/c/chromium/src/+/1425732
►

Sign in to add a comment