New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 923869 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: ----



Sign in to add a comment

Search Actions widget broken when kExternalFilesLoadedInWebState enabled

Project Member Reported by rkgibson@google.com, Yesterday (40 hours ago)

Issue description

Chrome Version (from "Settings > About Google Chrome"): 73.0.3680.0

Chrome quick actions widget broken when kExternalFilesLoadedInWebState is enabled. When the flag is enabled, if you start the app from one of the widget buttons, when you get to `openSelectedTabInMode`, URL is the external startup url, chromium-dev://x-callback-url/app-group-command. This fails the DCHECK, and then main_controller tries to open that url in a new tab, which fails. This breaks most of the opening options.
 

Comment 1 by olivierrobin@chromium.org, Yesterday (40 hours ago)

Cc: olivierrobin@chromium.org

Comment 2 by olivierrobin@chromium.org, Yesterday (38 hours ago)

https://cs.chromium.org/chromium/src/ios/chrome/app/application_delegate/user_activity_handler.mm?l=273

It seems that the kExternalFilesLoadedInWebState assume that the URL launched into Chrome can be loaded in the WebState.
For X-Callback-URL that are used to launch Chrome on extension action, this is not the case.

Comment 3 by twellington@google.com, Today (9 hours ago)

Labels: zine-triaged

Sign in to add a comment