Opening a window in the backgroundfetchclick event is crashing |
||
Issue descriptionRelevant stack trace: [112529:112529:0118/171252.612139:FATAL:navigation_controller_impl.cc(2812)] Check failed: !params.is_renderer_initiated || params.initiator_origin.has_value(). #0 0x7f664a727f39 base::debug::StackTrace::StackTrace() #1 0x7f664a570b55 base::debug::StackTrace::StackTrace() #2 0x7f664a5af973 logging::LogMessage::~LogMessage() #3 0x7f6645696614 content::NavigationControllerImpl::CreateNavigationRequestFromLoadParams() #4 0x7f664568dee2 content::NavigationControllerImpl::NavigateWithoutEntry() #5 0x7f664568d67b content::NavigationControllerImpl::LoadURLWithParams() #6 0x560eb240b58a (anonymous namespace)::LoadURLInContents() #7 0x560eb2409abd Navigate() #8 0x560eb045eaaa ChromeContentBrowserClient::OpenURL() #9 0x7f6645b452b9 content::service_worker_client_utils::(anonymous namespace)::OpenWindowOnUI()
,
Yesterday
(39 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eba98bdca607c38280c349afdcfb05a03ab64e7 commit 1eba98bdca607c38280c349afdcfb05a03ab64e7 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Jan 21 14:57:57 2019 Fill `initiator_origins` in OpenURLParams. The recently added initiator_origins field check was causing a crash when opening a new window from the service worker. Bug: 923848 Change-Id: I0ad54ce53ae42179ec3cc1aaefcc4785118f9306 Reviewed-on: https://chromium-review.googlesource.com/c/1422005 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#624582} [modify] https://crrev.com/1eba98bdca607c38280c349afdcfb05a03ab64e7/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/1eba98bdca607c38280c349afdcfb05a03ab64e7/chrome/test/data/background_fetch/sw.js [modify] https://crrev.com/1eba98bdca607c38280c349afdcfb05a03ab64e7/content/browser/service_worker/service_worker_client_utils.cc
,
Yesterday
(39 hours ago)
|
||
►
Sign in to add a comment |
||
Comment 1 by rayankans@chromium.org
, Yesterday (42 hours ago)