New issue
Advanced search Search tips

Issue 923828 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

applyConstraints() succeds when it should fail

Project Member Reported by guidou@google.com, Yesterday (43 hours ago)

Issue description

S = await navigator.mediaDevices.getUserMedia({audio: {echoCancellation: {exact: true}}})   // Succeeds

S.getAudioTracks()[0].applyConstraints({echoCancellation: {exact: false}})   // Should fail in current Chrome since no reconfiguration is supported


applyConstraints() in the above example should fail in Chrome, since it doesn't allow reconfiguring audio tracks, but it is currently suceeding (without reconfiguring).
 

Comment 1 by guidou@google.com, Yesterday (43 hours ago)

Cc: ar...@chromium.org
Labels: -Pri-3 Pri-2
Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by ar...@chromium.org, Yesterday (43 hours ago)

Cc: -ar...@chromium.org guidou@chromium.org
Owner: ar...@chromium.org

Comment 3 by ar...@chromium.org, Yesterday (38 hours ago)

This is already fixed in 73, possibly as a consequence of a recent re-write. I will add a test for it though.
Project Member

Comment 4 by bugdroid1@chromium.org, Today (15 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d56b202f05216e971e15c61d078e1f3fde6dc1e

commit 1d56b202f05216e971e15c61d078e1f3fde6dc1e
Author: Armando Miraglia <armax@chromium.org>
Date: Tue Jan 22 14:25:23 2019

[applyConstraints] Add web tests to avoid regressions on applyConstraints for EC.

We recently noticed that EC in previous versions of Chrome did not throw
and OverconstrainedError when applyConstraints() was given a
contraddicting EC value. This is currently fixed in upstream.

This CL adds a test to make sure such behaviour is tested and preserved
in the future, unless reconfiguration is allowed.

BUG=923828

Change-Id: I24201bc2f6d2dd153b40067046f706afad0d5702
Reviewed-on: https://chromium-review.googlesource.com/c/1425730
Commit-Queue: Armando Miraglia <armax@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624771}
[modify] https://crrev.com/1d56b202f05216e971e15c61d078e1f3fde6dc1e/third_party/blink/web_tests/fast/mediastream/MediaStreamTrack-applyConstraints.html

Sign in to add a comment