Regression: [NTP] Thumbnail Titles are not visible when dark chrome background is applied. |
|||
Issue descriptionChrome Version:73.0.3678.0 (Official Build) 657e8a65d00ae8de986ce0d7ef4d3f8a67bd008b-refs/branch-heads/3678@{#1} 32/64 bit OS: Windows(7,8,8.1,10) ,Mac(10.13.1 , 10.13.6 , 10.14.3)and Linux (14.04 LTS) Pre-condition: Enable 'Enable using the Google local NTP' under chrome://flags. What steps will reproduce the problem? 1. Launch chrome , navigate to NTP and add few thumbnails. 2. Click on Gear icon to open Customize this page overlay and select Chrome backgrounds. 3. Apply any dark chrome background and observe the thumbnail Titles. Actual : Thumbnail Titles are not visible when dark chrome background is applied. Expected: Thumbnail Titles should be visible even when dark chrome background is applied. This is a regression issue, broken in 'M-73', below is the per-revision bisect info: Good Build: 73.0.3676.0 (Revision: 624070) Bad Build: 73.0.3677.0 (Revision: 624410) You are probably looking for a change made after 624251 (known good), but no later than 624252 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/492f7c2f6f96f59f8aab79317faeeaa5136de83c..680ed8f316f5f4241b9a614043d88fa4f3ed8d83 Suspect: https://chromium.googlesource.com/chromium/src/+/680ed8f316f5f4241b9a614043d88fa4f3ed8d83 @Kristi : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the attached screen cast for reference. Thank You..!
,
Today
(7 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f8e80ae21b5448a59ee63f90b493120ceacf11f commit 9f8e80ae21b5448a59ee63f90b493120ceacf11f Author: Kristi Park <kristipark@chromium.org> Date: Tue Jan 22 22:28:12 2019 [NTP] Fix dark theme detection for custom backgrounds In the dark theme heuristic, only check for dark mode if there is no theme info. This fixes dark theme detection when only a custom background is set. Bug: 923797 Change-Id: I446148cfcee111438dc8137d97cafa1a380a6d78 Reviewed-on: https://chromium-review.googlesource.com/c/1427543 Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#624967} [modify] https://crrev.com/9f8e80ae21b5448a59ee63f90b493120ceacf11f/chrome/browser/resources/local_ntp/local_ntp.js
,
Today
(7 hours ago)
,
Today
(5 hours ago)
Prematurely marked as fixed |
|||
►
Sign in to add a comment |
|||
Comment 1 by twellington@google.com
, Today (9 hours ago)