New issue
Advanced search Search tips

Issue 923755 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 908767



Sign in to add a comment

Remove the temporary fix for crbug.com/908767

Project Member Reported by noel@chromium.org, Jan 20 (2 days ago)

Issue description

The temporary fix for: "Replace invalid Hindi SIZE units translations,   crbug.com/908767  " can be removed, now that Hindi strings with valid placeholders for the SIZE units have rolled into chrome.

 

Comment 1 by noel@chromium.org, Jan 21 (2 days ago)

Labels: bad-i18n-placeholders

Comment 2 by noel@chromium.org, Jan 21 (2 days ago)

Description: Show this description

Comment 3 by noel@chromium.org, Jan 21 (2 days ago)

Blockedon: 908767

Comment 4 by noel@chromium.org, Jan 21 (2 days ago)

Labels: M-73
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 21 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7335aa15f67995135f60cf5e5b2c54bbca202c5

commit d7335aa15f67995135f60cf5e5b2c54bbca202c5
Author: Noel Gordon <noel@chromium.org>
Date: Mon Jan 21 00:39:24 2019

Remove the temporary fix for  crbug.com/908767 

Hindi strings with valid placeholders for these SIZE units have rolled
into chrome. The temporary fix can be removed therefore.

Bug:  923755 
Change-Id: I1e5d3c5bcef9c0c381ace42651b69361c62d5a2b
Reviewed-on: https://chromium-review.googlesource.com/c/1424618
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624499}
[modify] https://crrev.com/d7335aa15f67995135f60cf5e5b2c54bbca202c5/ui/file_manager/file_manager/common/js/util.js

Comment 6 by noel@chromium.org, Jan 21 (2 days ago)

Status: Fixed (was: Started)

Comment 7 by noel@google.com, Jan 21 (2 days ago)

> now that Hindi strings with valid placeholders for the SIZE units have rolled into chrome ...

on https://chromium-review.googlesource.com/c/chromium/src/+/1404380


Sign in to add a comment