Roll clang 350768:351477 breaks ChromeOS PFQ builds |
||||
Issue descriptionAll ChromeOS builds are broken, for example: https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8923817237784438928/+/steps/BuildPackages/0/stdout Relevant Cl: https://chromium-review.googlesource.com/c/chromium/src/+/1418440 chromeos-chrome-73.0.3678.0_rc-r1: [237/49020] CC obj/native_client/src/shared/platform/platform/lock.o[K chromeos-chrome-73.0.3678.0_rc-r1: FAILED: obj/native_client/src/shared/platform/platform/lock.o chromeos-chrome-73.0.3678.0_rc-r1: /home/chrome-bot/goma/gomacc x86_64-cros-linux-gnu-clang -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -MMD -MF obj/native_client/src/shared/platform/platform/lock.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"351477-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCR_SYSROOT_HASH=e7c53f04bd88d29d075bfd1f62b073aeb69cbe09 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -D_GNU_SOURCE=1 -D__STDC_LIMIT_MACROS=1 -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -fno-strict-aliasing -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -flto=thin -fsplit-lto-unit -fwhole-program-vtables -m64 -march=x86-64 -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf -ggnu-pubnames -fsanitize=cfi-vcall -fsanitize-blacklist=../../../../../../../home/chrome-bot/chrome_root/src/tools/cfi/blacklist.txt -fsanitize=cfi-derived-cast -fsanitize=cfi-unrelated-cast -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c11 --sysroot=../../../../../../../build/amd64-generic -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -fdebug-info-for-profiling -faddrsig -Wno-unknown-warning-option -c ../../../../../../../home/chrome-bot/chrome_root/src/native_client/src/shared/platform/posix/lock.c -o obj/native_client/src/shared/platform/platform/lock.o chromeos-chrome-73.0.3678.0_rc-r1: clang: [0;1;31merror: [0munknown argument: '-fsplit-lto-unit'[0m
,
Jan 20
(2 days ago)
Sorry I don't want to try and make CLs to fix things that I don't understand.
,
Jan 20
(2 days ago)
Can you answer the other questions?
,
Jan 21
(2 days ago)
"The Pre-Flight-Queue (PFQ) tests daily Chrome branches against tip-of-tree Chrome OS" -> See https://docs.google.com/document/d/1sy2pgG5PpACeOlqrD4dbydhBVPnKpUnZ_H2G_2CgcJo/edit#heading=h.q60vsea3mk0d I'm only a shadow gardener so I'm not an expert in the how's and the whys.
,
Jan 21
(2 days ago)
Sorry should have linked to the queue's as well: https://cros-goldeneye.corp.google.com/chromeos/legoland/builderSummary?builderGroups=chrome_pfq%2Cchrome_informational&limit=3&buildBranch=master
,
Jan 21
(2 days ago)
Do you know who wrote that doc or who owns that build config? Who uses this build config? Is P3 appropriate for this? If yes, why are you reverting for this? If no, why doesn't this config have a cq bot?
,
Jan 21
(2 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/808a2b60a1236f7e1c857f6ee82c27e9ce1baa53 commit 808a2b60a1236f7e1c857f6ee82c27e9ce1baa53 Author: Stuart Langley <slangley@google.com> Date: Mon Jan 21 02:13:54 2019 Speculative fix for chromeos not supporting split-lto-unit cflag. Building chrome on chromeos breaks with unknown argument: '-fsplit-lto-unit'. Bug: 923750 Change-Id: I43ce222eba4334fd2fc2f34103b4b9ee209e6ead Reviewed-on: https://chromium-review.googlesource.com/c/1424620 Commit-Queue: Stuart Langley <slangley@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#624508} [modify] https://crrev.com/808a2b60a1236f7e1c857f6ee82c27e9ce1baa53/build/config/compiler/BUILD.gn
,
Yesterday
(28 hours ago)
Looks like there were a bunch of green builds today on https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod so I'm guessing this is fine now. slangley, can you answer the questions on #6 please?
,
Yesterday
(27 hours ago)
assigning to stevenjb@ who is our gardening expert and is better positioned to answer your questions.
,
Today
(11 hours ago)
I opened issue 924192 to track adding CQ coverage for this, or deciding not to add it. Let's discuss more there, since this issue is closed now.
,
Today
(6 hours ago)
Filed Issue 924362. To remember to remove the workaround. |
||||
►
Sign in to add a comment |
||||
Comment 1 by thakis@chromium.org
, Jan 20 (2 days ago)Cc: llozano@chromium.org
Components: Build
Owner: slangley@chromium.org