New issue
Advanced search Search tips

Issue 923685 link

Starred by 13 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

I cannot sign in to GitHub with the last Canary

Reported by vsemozhe...@gmail.com, Jan 19 (3 days ago)

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3677.0 Safari/537.36

Example URL:
https://github.com/login

Steps to reproduce the problem:
1. Log out from GitHub.
2. Try to log in.

What is the expected behavior?

What went wrong?
This page isn’t working
github.com didn’t send any data.
ERR_EMPTY_RESPONSE

Did this work before? Yes Previous or before previous. 73.0.3673.0 dev is OK.

Chrome version: 73.0.3677.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Before log out, I could not comment or use reactions.
 

Comment 1 by vsemozhe...@gmail.com, Jan 19 (3 days ago)

The same with "chrome.exe --user-data-dir=fresh-profile"

Comment 2 by woxxom@gmail.com, Jan 20 (2 days ago)

Bisected to 624379 (good) - 624385 (bad)
https://chromium.googlesource.com/chromium/src/+log/fb4408bf..fc36572d?pretty=fuller

Suspecting r624380 = 68df3afe5a62b4bb8f7ec57130f4e8e7002867e9 = crrev.com/c/1423423 by agl@chromium.org
"Send KeyUpdates after the first post-handshake write."
Landed in 73.0.3677.0

TE@, you can use any bogus user and password like abc.

Comment 3 by woxxom@gmail.com, Jan 20 (2 days ago)

Confirmed the suspect by successfully signing in after disabling the feature with a command line switch:
--disable-features=TLS13KeyUpdate

Comment 4 by agl@chromium.org, Jan 20 (2 days ago)

Owner: agl@chromium.org
Status: Started (was: Unconfirmed)
That uncovered an issue faster than expected! Thanks for using Canary and tracking it down. I'll disable this today and try to find the correct contact at GitHub.

Comment 5 by agl@chromium.org, Jan 20 (2 days ago)

Labels: -Arch-x86_64 ReleaseBlock-Dev Arch-All

Comment 6 by woxxom@gmail.com, Jan 20 (2 days ago)

Same issue with twitter and supposedly other EdgeCast CDN:  bug 923719 .

Comment 7 by sora...@gmail.com, Jan 20 (2 days ago)

FYI, https://gravatar.com/ is also affected.

Comment 8 by agl@chromium.org, Jan 20 (2 days ago)

 Issue 923719  has been merged into this issue.

Comment 9 by agl@chromium.org, Jan 20 (2 days ago)

 Issue 923732  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 20 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cee722a155e623809cc241d27bdb35fe278135f4

commit cee722a155e623809cc241d27bdb35fe278135f4
Author: Adam Langley <agl@chromium.org>
Date: Sun Jan 20 19:29:27 2019

Disable sending KeyUpdates by default.

68df3afe5a62b4bb8f7ec57130f4e8e7002867e9 was intended to find buggy
servers that don't implement TLS 1.3 KeyUpdate correctly, and it didn't
take long to find some (see bug). This change disables sending
KeyUpdates by default until we've figured out those sites.

TBR=davidben@chromium.org

Bug:  923685 
Change-Id: I44968fa85b2b92e18579e7d0fbd13b4b93ecffff
Reviewed-on: https://chromium-review.googlesource.com/c/1424419
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624492}
[modify] https://crrev.com/cee722a155e623809cc241d27bdb35fe278135f4/net/base/features.cc

Comment 11 by agl@google.com, Jan 20 (2 days ago)

Status: Fixed (was: Started)

Comment 12 by meh...@chromium.org, Jan 20 (2 days ago)

 Issue 923708  has been merged into this issue.

Comment 13 by agl@chromium.org, Jan 20 (2 days ago)

Ultimately this turned out to be an issue with HAProxy: https://www.mail-archive.com/haproxy@formilux.org/msg32495.html

Comment 14 by agl@chromium.org, Jan 21 (2 days ago)

 Issue 923749  has been merged into this issue.

Comment 15 by vamshi.kommuri@chromium.org, Yesterday (44 hours ago)

Labels: TE-Verified-M73 TE-Verified-73.0.3679.0
Verified the fix on Windows-10 using Chrome version #73.0.3679.0 as per the comment #0.
Attaching screen shot for reference.
Observed that we could sign in to GitHub.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!
923685.jpg
330 KB View Download

Sign in to add a comment