New issue
Advanced search Search tips

Issue 923682 link

Starred by 1 user
Status: Assigned
Owner:
pauljensen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

HostResolverImplDnsTest.BypassDnsTask fails due to ERR_NETWORK_CHANGED results.

Project Member Reported by w...@chromium.org, Jan 19 (3 days ago) 
HostResolverImplDnsTest.BypassDnsTask flaked in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/27682 due to unexpected NETWORK_CHANGED responses:

[ RUN      ] HostResolverImplDnsTest.BypassDnsTask
../../net/dns/host_resolver_impl_unittest.cc:4806: Failure
Expected equality of these values:
  ERR_NAME_NOT_RESOLVED
    Which is: -105
  requests_[i]->WaitForResult()
    Which is: -21
0
Stack trace:
#00: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) at gtest.cc:?
#01: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:?
#02: net::HostResolverImplDnsTest_BypassDnsTask_Test::TestBody() at host_resolver_impl_unittest.cc:?

../../net/dns/host_resolver_impl_unittest.cc:4806: Failure
Expected equality of these values:
  ERR_NAME_NOT_RESOLVED
    Which is: -105
  requests_[i]->WaitForResult()
    Which is: -21
1
Stack trace:
#00: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) at gtest.cc:?
#01: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:?
#02: net::HostResolverImplDnsTest_BypassDnsTask_Test::TestBody() at host_resolver_impl_unittest.cc:?

../../net/dns/host_resolver_impl_unittest.cc:4809: Failure
Expected equality of these values:
  OK
    Which is: 0
  requests_[i]->WaitForResult()
    Which is: -21
2
Stack trace:
#00: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) at gtest.cc:?
#01: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:?
#02: net::HostResolverImplDnsTest_BypassDnsTask_Test::TestBody() at host_resolver_impl_unittest.cc:?

../../net/dns/host_resolver_impl_unittest.cc:4809: Failure
Expected equality of these values:
  OK
    Which is: 0
  requests_[i]->WaitForResult()
    Which is: -21
3
Stack trace:
#00: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) at gtest.cc:?
#01: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:?
#02: net::HostResolverImplDnsTest_BypassDnsTask_Test::TestBody() at host_resolver_impl_unittest.cc:?

../../net/dns/host_resolver_impl_unittest.cc:4809: Failure
Expected equality of these values:
  OK
    Which is: 0
  requests_[i]->WaitForResult()
    Which is: -21
4
Stack trace:
#00: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) at gtest.cc:?
#01: testing::internal::AssertHelper::operator=(testing::Message const&) const at gtest.cc:?
#02: net::HostResolverImplDnsTest_BypassDnsTask_Test::TestBody() at host_resolver_impl_unittest.cc:?

[  FAILED  ] HostResolverImplDnsTest.BypassDnsTask (15 ms)

Comment 1 by pauljensen@chromium.org, Today (15 hours ago) 

The -21 is ERR_NETWORK_CHANGED.
Weird because net_unittests should only have a mock NetworkChangeNotifier in place, created here:
https://cs.chromium.org/chromium/src/net/test/net_test_suite.cc?rcl=06c419e1967a41ce51d1052405ceaa5a63669df8&l=38

Comment 2 by w...@chromium.org, Today (12 hours ago)

Owner: pauljensen@chromium.org
Status: Assigned (was: Untriaged)
Re #1: HostResolverImpl has several code paths which return ERR_NETWORK_CHANGED in response to events other than NetworkChangeNotifier notifications, e.g:

Abort() calls:
https://cs.chromium.org/chromium/src/net/dns/host_resolver_impl.cc?type=cs&q=ERR_NETWORK_CHANGED&sq=package:chromium&g=0&l=1592

SetDnsClient() calls:
https://cs.chromium.org/chromium/src/net/dns/host_resolver_impl.cc?type=cs&q=ERR_NETWORK_CHANGED&sq=package:chromium&g=0&l=2273

I don't know what "BypassDnsTask" means in terms of what this test is doing, though, so I'm unsure of why it might be triggering those calls to be made.
►

Sign in to add a comment