New issue
Advanced search Search tips

Issue 923645 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

safe_browing missing dependency on //chrome/browser

Project Member Reported by pwnall@chromium.org, Jan 19 (3 days ago)

Issue description

I suspect that //chrome/browser/downloads will need to be pulled into its own target, or that safe_browsing will need to be refactored.

Build error that closed the tree: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/9928

Compilation errors below. The theme seems to be that safe_browsing files include //chrome/browser/ui/browser.h directly, via //chrome/browser/download/download_commands.h, or via other files in //chrome/browser/ui.


FAILED: obj/chrome/browser/safe_browsing/test_support/test_safe_browsing_service.obj 
*snip* ../../chrome/browser/safe_browsing/test_safe_browsing_service.cc /Foobj/chrome/browser/safe_browsing/test_support/test_safe_browsing_service.obj /Fd"obj/chrome/browser/safe_browsing/test_support_cc.pdb"
In file included from ../../chrome/browser/safe_browsing/test_safe_browsing_service.cc:8:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.



[70565/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/safe_browsing_controller_client.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/safe_browsing_controller_client.obj 
*snip* ../../chrome/browser/safe_browsing/safe_browsing_controller_client.cc
In file included from ../../chrome/browser/safe_browsing/safe_browsing_controller_client.cc:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70567/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_navigation_util_win.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_navigation_util_win.obj 
*snip* ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_navigation_util_win.cc
In file included from ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_navigation_util_win.cc:5:
In file included from ../..\chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_navigation_util_win.h:8:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70568/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/services_delegate_desktop.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/services_delegate_desktop.obj 
*snip* ../../chrome/browser/safe_browsing/services_delegate_desktop.cc
In file included from ../../chrome/browser/safe_browsing/services_delegate_desktop.cc:5:
In file included from ../..\chrome/browser/safe_browsing/services_delegate_desktop.h:13:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70569/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/settings_reset_prompt_controller.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/settings_reset_prompt_controller.obj 
*snip* ../../chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc
In file included from ../../chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc:23:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70570/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_dialog_controller_impl_win.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_dialog_controller_impl_win.obj 
*snip* ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc
In file included from ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc:12:
In file included from ../..\chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_navigation_util_win.h:8:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70571/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/incident_reporting_service.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/incident_reporting_service.obj 
*snip* ../../chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
In file included from ../../chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc:5:
In file included from ../..\chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h:21:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70572/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/reporter_runner_win.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/reporter_runner_win.obj 
*snip* ../../chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
In file included from ../../chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc:42:
In file included from ../..\chrome/browser/ui/browser_finder.h:10:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70573/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/check_client_download_request.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/check_client_download_request.obj 
*snip* ../../chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
In file included from ../../chrome/browser/safe_browsing/download_protection/check_client_download_request.cc:18:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_feedback_service.h:14:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70574/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/download_feedback_service.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/download_feedback_service.obj 
*snip* ../../chrome/browser/safe_browsing/download_protection/download_feedback_service.cc
In file included from ../../chrome/browser/safe_browsing/download_protection/download_feedback_service.cc:5:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_feedback_service.h:14:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70575/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/download_protection_service.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/download_protection_service.obj 
*snip* ../../chrome/browser/safe_browsing/download_protection/download_protection_service.cc
In file included from ../../chrome/browser/safe_browsing/download_protection/download_protection_service.cc:5:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70576/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/settings_reset_prompt_util_win.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/settings_reset_prompt_util_win.obj 
*snip* ../../chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_util_win.cc
In file included from ../../chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_util_win.cc:22:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70577/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_reboot_dialog_controller_impl_win.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_reboot_dialog_controller_impl_win.obj 
*snip* ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_reboot_dialog_controller_impl_win.cc
In file included from ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_reboot_dialog_controller_impl_win.cc:11:
In file included from ../..\chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_navigation_util_win.h:8:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70578/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/last_download_finder.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/last_download_finder.obj 
*snip* ../../chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
In file included from ../../chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc:24:
In file included from ../..\chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h:21:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70579/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/settings_resetter_win.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/settings_resetter_win.obj 
*snip* ../../chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
In file included from ../../chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc:27:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70580/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/download_url_sb_client.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/download_url_sb_client.obj 
*snip* ../../chrome/browser/safe_browsing/download_protection/download_url_sb_client.cc
In file included from ../../chrome/browser/safe_browsing/download_protection/download_url_sb_client.cc:12:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70581/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_controller_impl_win.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/chrome_cleaner_controller_impl_win.obj 
*snip* ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
In file included from ../../chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc:31:
In file included from ../..\chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_navigation_util_win.h:8:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70582/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/extension_data_collection.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/extension_data_collection.obj 
*snip* ../../chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc
In file included from ../../chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc:14:
In file included from ../..\chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h:21:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70583/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/safe_browsing_service.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/safe_browsing_service.obj 
*snip* ../../chrome/browser/safe_browsing/safe_browsing_service.cc
In file included from ../../chrome/browser/safe_browsing/safe_browsing_service.cc:59:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70584/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/ppapi_download_request.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/ppapi_download_request.obj 
*snip* ../../chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc
In file included from ../../chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc:13:
In file included from ../..\chrome/browser/safe_browsing/download_protection/download_protection_service.h:26:
In file included from ../..\chrome/browser/download/download_commands.h:11:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.


[70585/78674] CXX obj/chrome/browser/safe_browsing/safe_browsing/chrome_password_protection_service.obj
FAILED: obj/chrome/browser/safe_browsing/safe_browsing/chrome_password_protection_service.obj 
*snip* ../../chrome/browser/safe_browsing/chrome_password_protection_service.cc
In file included from ../../chrome/browser/safe_browsing/chrome_password_protection_service.cc:31:
In file included from ../..\chrome/browser/ui/views/frame/browser_view.h:24:
In file included from ../..\chrome/browser/ui/browser.h:40:
../..\components/translate/content/browser/content_translate_driver.h(13,10):  fatal error: 'components/translate/content/common/translate.mojom.h' file not found
#include "components/translate/content/common/translate.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
 

Comment 1 by pwnall@chromium.org, Jan 19 (3 days ago)

Cc: nparker@chromium.org jsc...@chromium.org vakh@chromium.org
Variations on this problem have been reported as Issue 919683 and Issue 920222 and Issue 920223 since Jan 7. Please find someone who can fix this. Build breakages are slowing down everyone else as they may cause unnecessary tree closure and reverts.

Sign in to add a comment