New issue
Advanced search Search tips

Issue 923616 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 923628

Blocking:
issue 923564



Sign in to add a comment

Figure out which gtest_perf_tests are outputting perf data incorrectly

Project Member Reported by crouleau@chromium.org, Jan 19 (4 days ago)

Issue description

Comment 1 by crouleau@chromium.org, Jan 19 (4 days ago)

Output format is supposed to be

// <*>RESULT <graph_name>: <trace_name>= {<mean>, <std deviation>} <units>

where graph_name = metric and trace_name = story. Many tests have metric and story switched.

Comment 2 by crouleau@chromium.org, Jan 19 (4 days ago)

Wrote this to catch low-hanging fruit: https://chromium-review.googlesource.com/c/chromium/src/+/1423673

Comment 3 by crouleau@chromium.org, Jan 19 (4 days ago)

Components: Speed>Benchmarks
media_perftests seems fine. Seems like we just need to fix https://bugs.chromium.org/p/chromium/issues/detail?id=918601#c16
so that it always outputs with _biggerIsBetter or _smallerIsBetter

Brian, for a line like this
*RESULT clockless_video_playback_vp8: bear_silent.webm= 53.406108056578425 runs/s

do we want to modify to 

A.
*RESULT clockless_video_playback_vp8: bear_silent.webm= 53.406108056578425 runs/s_biggerIsBetter

or 

B.
*RESULT clockless_video_playback_vp8_biggerIsBetter: bear_silent.webm= 53.406108056578425 runs/s

?

Comment 4 by crouleau@chromium.org, Jan 19 (4 days ago)

Blockedon: 923628

Sign in to add a comment