WMITest.TestCreateClassMethod is flaky in base_unittests |
||
Issue descriptionFlakiness dashboard : https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=base_unittests&tests=WMITest.TestCreateClassMethod @grt for triage Typical flake : [ RUN ] WMITest.TestCreateClassMethod Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: (No symbol) [0x00007FF90587A548] Microsoft::WRL::ComPtr<IWbemClassObject>::InternalRelease [0x00007FF74F7737E6+86] Microsoft::WRL::ComPtr<IWbemClassObject>::~ComPtr<IWbemClassObject> [0x00007FF74F7722A3+19] base::win::WMITest_TestCreateClassMethod_Test::TestBody [0x00007FF74F7720EE+1918] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF74F7F385F+79] testing::Test::Run [0x00007FF74F7F37C9+185] testing::TestInfo::Run [0x00007FF74F7F4497+231] testing::TestCase::Run [0x00007FF74F7F4FA0+240] testing::internal::UnitTestImpl::RunAllTests [0x00007FF74F7FEB1D+765] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00007FF74F7FE805+85] testing::UnitTest::Run [0x00007FF74F7FE653+307] RUN_ALL_TESTS [0x00007FF74F950201+17] base::TestSuite::Run [0x00007FF74F94F7F3+163] ??$Invoke@P8TestSuite@base@@EAAHXZPEAV12@$$V@?$FunctorTraits@P8TestSuite@base@@EAAHXZX@internal@base@@SAHP8TestSuite@2@EAAHXZ$$QEAPEAV32@@Z [0x00007FF74F94F25A+26] base::internal::InvokeHelper<0,int>::MakeItSo<int (__cdecl base::TestSuite::*const & __ptr64)(void) __ptr64,base::TestSuite * __ptr64> [0x00007FF74F94F1D4+52] base::internal::Invoker<base::internal::BindState<int (__cdecl base::TestSuite::*)(void) __ptr64,base::internal::UnretainedWrapper<base::TestSuite> >,int __cdecl(void)>::RunImpl<int (__cdecl base::TestSuite::*const & __ptr64)(void) __ptr64,std::tuple<base [0x00007FF74F94F178+88] base::internal::Invoker<base::internal::BindState<int (__cdecl base::TestSuite::*)(void) __ptr64,base::internal::UnretainedWrapper<base::TestSuite> >,int __cdecl(void)>::Run [0x00007FF74F94F08C+60] base::OnceCallback<int __cdecl(void)>::Run [0x00007FF74E56E601+97] base::LaunchUnitTests [0x00007FF74F9530E0+752] base::LaunchUnitTests [0x00007FF74F952EED+253] main [0x00007FF74F94EE68+152] invoke_main [0x00007FF74F9948F4+52] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79) __scrt_common_main_seh [0x00007FF74F994A2E+302] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) __scrt_common_main [0x00007FF74F994AAE+14] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331) mainCRTStartup [0x00007FF74F994AC9+9] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x00007FF912082774+20] RtlUserThreadStart [0x00007FF914840D51+33]
,
Yesterday
(36 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eef6caef5b84e632e27867618d3e3e77d0aee29d commit eef6caef5b84e632e27867618d3e3e77d0aee29d Author: Greg Thompson <grt@chromium.org> Date: Mon Jan 21 18:03:17 2019 Deflake WMITest tests. These tests were reaching through a ComPtr to call Release on underlying interface pointers. This is a no-no, as the ComPtr still thinks it's holding a ref on the interface and will Release again in its dtor. This is a crashtrocity. This here CL changes such calls to the Reset method on the ComPtr itself, which does what the test actually intended: releases the ref held on the interface pointer and forgets about it. BUG= 923562 R=gab@chromium.org Change-Id: Ie7276f868e88eb63e19605d877fc5c9373564fbf Reviewed-on: https://chromium-review.googlesource.com/c/1424942 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624616} [modify] https://crrev.com/eef6caef5b84e632e27867618d3e3e77d0aee29d/base/win/wmi_unittest.cc
,
Today
(21 hours ago)
|
||
►
Sign in to add a comment |
||
Comment 1 by grt@chromium.org
, Yesterday (41 hours ago)