New issue
Advanced search Search tips

Issue 923535 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
perezju@chromium.org
eyaich@chromium.org
crouleau@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename performance_webview_test_suite to performance_test_suite

Project Member Reported by crouleau@chromium.org, Jan 18 (4 days ago) 
When you are using https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=performance_test_suite

It is hard to remember to select performance_webview_test_suite instead of performance_test_suite

Is there some technical reason why we can't name them the same thing?

Comment 1 by perezju@google.com, Yesterday (44 hours ago) 

I agree it's confusing, and hopefully we can come up with a better solution.

There are some comments in the definition of these gn targets that probably explain the rationale:
https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?rcl=c8bf6be7b393ded410fdfcda0889505ed884d947&l=2281

Not sure exactly where does the "runs a devil script before the build, to remove the system webview" happens; but presumably we could do the same thing for both targets.

Comment 2 by eyaich@chromium.org, Today (15 hours ago) 

This is the call to the script: https://cs.chromium.org/chromium/src/testing/buildbot/gn_isolate_map.pyl?q=performance_webview_test_suite&sq=package:chromium&dr=C&l=2039

I don't know what this would do on a desktop bot if you ran this script first.

Comment 3 by perezju@chromium.org, Today (7 hours ago) 

Ah! Thanks for finding that Emily. Yeah, that probably won't work everywhere, specially desktop targets.

Maybe the alternative is to fold the call to that script (devil/android/tools/system_app.py) within testing/scripts/run_performance_tests.py ?
►

Sign in to add a comment