New issue
Advanced search Search tips

Issue 923526 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Some entity suggestion images are distorted

Project Member Reported by jdonnelly@chromium.org, Jan 18 (4 days ago)

Issue description

Steps to reproduce:
1. Enable entity suggestions at chrome://flags/#omnibox-rich-entity-suggestions.
2. Restart browser.
3. Type "Tay-K" in the omnibox. An entity suggestion with an image and the description "Rapper" should appear in the list of suggestions.

Actual outcome:
The image is resized to fit in the square-shaped area reserved for the entity image, but the original aspect ratio is not preserved so the image looks distorted. (See first attached screenshot.)

Expected outcome:
The image should be resized to fit in the square-shaped area reserved for the entity image, while preserving the original aspect ratio. (See second attached screenshot, showing how the same image appears in the Google app.)

Background:
The image is supposed to already be formatted in a square aspect ratio by the suggestions server, and virtually all entity images are. However, in rare cases, it returns an image with a non-square ratio. Currently, I can only reproduce this with the Tay-K entity but I know I've seen it in at least one other case that I can't remember now. Even though the server is violating this expectation, we should still handle this case gracefully and preserve aspect ratio when resizing in Chrome.

 

Sign in to add a comment